From: Randy Dunlap <rdunlap@xenotime.net>
To: Andi Kleen <ak@linux.intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Andi Kleen <andi@firstfloor.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
greg@kroah.com
Subject: Re: [PATCH] USB: Build usb_speed_string unconditionally
Date: Mon, 20 Aug 2012 13:27:43 -0700 [thread overview]
Message-ID: <50329DBF.9060206@xenotime.net> (raw)
In-Reply-To: <20120820195808.GD4461@tassilo.jf.intel.com>
On 08/20/12 12:58, Andi Kleen wrote:
> On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
>> On Mon, 20 Aug 2012, Andi Kleen wrote:
>>
>>> From: Andi Kleen <ak@linux.intel.com>
>>>
>>> The usb core uses usb_speed_string(). But it's only selected
>>> for USB_GADGET. Enable it unconditionally.
>>
>> What are you talking about? USB_COMMON isn't selected at all, but it
>> does get built whenever USB or USB_GAGDET is enabled. From
>> drivers/usb/Kconfig:
>
> Just trying to fix my LTO randconfigs.
>
> Here's a config that violated it on rc2.
Involves known problem with DRM_USB AFAICT.
Greg just accepted a patch from Guenter Roeck that should
fix this:
[PATCH RESEND] gpu/mfd/usb: Fix USB randconfig problems
--
~Randy
next prev parent reply other threads:[~2012-08-20 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 19:38 [PATCH] USB: Build usb_speed_string unconditionally Andi Kleen
2012-08-20 19:47 ` Alan Stern
2012-08-20 19:58 ` Andi Kleen
2012-08-20 20:27 ` Randy Dunlap [this message]
2012-08-20 20:42 ` Alan Stern
2012-08-20 20:49 ` Greg KH
2012-08-20 21:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50329DBF.9060206@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).