From: Sergei Shtylyov <sshtylyov@mvista.com>
To: manoj.iyer@canonical.com
Cc: linux-kernel@vger.kernel.org, sarah.a.sharp@linux.intel.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup
Date: Tue, 21 Aug 2012 15:21:09 +0400 [thread overview]
Message-ID: <50336F25.80706@mvista.com> (raw)
In-Reply-To: <1345522015-13740-1-git-send-email-manoj.iyer@canonical.com>
Hello.
On 21-08-2012 8:06, manoj.iyer@canonical.com wrote:
> From: Manoj Iyer <manoj.iyer@canonical.com>
> USB 3.0 devices show up as high-speed devices on powerup, after an
> s3 cycle they are correctly recognized as SuperSpeed. At powerup
> unconditionally switch the port to xHCI like we do when we resume
> from suspend.
> BugLink: http://bugs.launchpad.net/bugs/1000424
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
> drivers/usb/host/xhci-pci.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 9bfd4ca11..5c8dbea 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -48,6 +48,14 @@ static int xhci_pci_reinit(struct xhci_hcd *xhci, struct pci_dev *pdev)
> if (!pci_set_mwi(pdev))
> xhci_dbg(xhci, "MWI active\n");
>
> + /*
> + * USB SuperSpeed ports are recognized as HighSpeed ports on powerup
Devices, not ports?
> + * unconditionally switch the ports to xHCI like we do when resume
s/resume/resuming/
> + * from suspend.
> + */
> + if (usb_is_intel_switchable_xhci(pdev))
> + usb_enable_xhci_ports(pdev);
> +
WBR, Sergei
next prev parent reply other threads:[~2012-08-21 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 4:06 [PATCH 0/1] xhci: Unconditionally switch ports to xHCI on powerup manoj.iyer
2012-08-21 4:06 ` [PATCH 1/1] " manoj.iyer
2012-08-21 11:21 ` Sergei Shtylyov [this message]
2012-08-21 12:12 ` Andiry Xu
2012-08-21 16:16 ` Manoj Iyer
2012-08-22 3:31 ` Andiry Xu
2012-08-22 16:09 ` Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50336F25.80706@mvista.com \
--to=sshtylyov@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manoj.iyer@canonical.com \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox