[PATCH RESEND] extcon: fix typos in sys-class-extcon

[PATCH RESEND] extcon: fix typos in sys-class-extcon

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 Documentation/ABI/testing/sysfs-class-extcon |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-class-extcon b/Documentation/ABI/testing/sysfs-class-extcon
index 20ab361..57a7262 100644
--- a/Documentation/ABI/testing/sysfs-class-extcon
+++ b/Documentation/ABI/testing/sysfs-class-extcon
@@ -13,7 +13,7 @@ Description:
 		accessory cables have such capability. For example,
 		the 30-pin port of Nuri board (/arch/arm/mach-exynos)
 		may have both HDMI and Charger attached, or analog audio,
-		video, and USB cables attached simulteneously.
+		video, and USB cables attached simultaneously.
 
 		If there are cables mutually exclusive with each other,
 		such binary relations may be expressed with extcon_dev's
@@ -35,7 +35,7 @@ Description:
 		The /sys/class/extcon/.../state shows and stores the cable
 		attach/detach information of the corresponding extcon object.
 		If the extcon object has an optional callback "show_state"
-		defined, the showing function is overriden with the optional
+		defined, the showing function is overridden with the optional
 		callback.
 
 		If the default callback for showing function is used, the
@@ -46,19 +46,19 @@ Description:
 		TA=1
 		EAR_JACK=0
 		#
-		In this example, the extcon device have USB_OTG and TA
+		In this example, the extcon device has USB_OTG and TA
 		cables attached and HDMI and EAR_JACK cables detached.
 
 		In order to update the state of an extcon device, enter a hex
-		state number starting with 0x.
-		 echo 0xHEX > state
+		state number starting with 0x:
+		# echo 0xHEX > state
 
-		This updates the whole state of the extcon dev.
+		This updates the whole state of the extcon device.
 		Inputs of all the methods are required to meet the
-		mutually_exclusive contidions if they exist.
+		mutually_exclusive conditions if they exist.
 
 		It is recommended to use this "global" state interface if
-		you need to enter the value atomically. The later state
+		you need to set the value atomically. The later state
 		interface associated with each cable cannot update
 		multiple cable states of an extcon device simultaneously.
 
@@ -73,7 +73,7 @@ What:		/sys/class/extcon/.../cable.x/state
 Date:		February 2012
 Contact:	MyungJoo Ham <myungjoo.ham@samsung.com>
 Description:
-		The /sys/class/extcon/.../cable.x/name shows and stores the
+		The /sys/class/extcon/.../cable.x/state shows and stores the
 		state of cable "x" (integer between 0 and 31) of an extcon
 		device. The state value is either 0 (detached) or 1
 		(attached).
@@ -83,8 +83,8 @@ Date:		December 2011
 Contact:	MyungJoo Ham <myungjoo.ham@samsung.com>
 Description:
 		Shows the relations of mutually exclusiveness. For example,
-		if the mutually_exclusive array of extcon_dev is
-		{0x3, 0x5, 0xC, 0x0}, the, the output is:
+		if the mutually_exclusive array of extcon device is
+		{0x3, 0x5, 0xC, 0x0}, then the output is:
 		# ls mutually_exclusive/
 		0x3
 		0x5
-- 
1.7.9.5

[PATCH RESEND] extcon: fix typos in max77693 driver

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/extcon/extcon-max77693.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 920a609..8bb438b 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -356,7 +356,7 @@ static int max77693_muic_adc_ground_handler(struct max77693_muic_info *info,
 		extcon_set_cable_state(info->edev, "MHL", attached);
 		break;
 	default:
-		dev_err(info->dev, "faild to detect %s accessory\n",
+		dev_err(info->dev, "failed to detect %s accessory\n",
 			attached ? "attached" : "detached");
 		dev_err(info->dev, "- adc:0x%x, adclow:0x%x, adc1k:0x%x\n",
 			adc, adclow, adc1k);
@@ -548,7 +548,7 @@ static void max77693_muic_irq_work(struct work_struct *work)
 		curr_adc = info->status[0] & STATUS1_ADC_MASK;
 		curr_adc >>= STATUS1_ADC_SHIFT;
 
-		/* Check accossory state which is either detached or attached */
+		/* Check accessory state which is either detached or attached */
 		if (curr_adc == MAX77693_MUIC_ADC_OPEN)
 			attached = false;
 
@@ -564,7 +564,7 @@ static void max77693_muic_irq_work(struct work_struct *work)
 		curr_chg_type = info->status[1] & STATUS2_CHGTYP_MASK;
 		curr_chg_type >>= STATUS2_CHGTYP_SHIFT;
 
-		/* Check charger accossory state which
+		/* Check charger accessory state which
 		   is either detached or attached */
 		if (curr_chg_type == MAX77693_CHARGER_TYPE_NONE)
 			attached = false;
-- 
1.7.9.5

[PATCH RESEND] extcon: fixing typos

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/extcon/extcon_class.c |    8 ++++----
 include/linux/extcon.h        |   18 +++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/extcon/extcon_class.c b/drivers/extcon/extcon_class.c
index f6419f9..fa56339 100644
--- a/drivers/extcon/extcon_class.c
+++ b/drivers/extcon/extcon_class.c
@@ -442,7 +442,7 @@ static int _call_per_cable(struct notifier_block *nb, unsigned long val,
 
 /**
  * extcon_register_interest() - Register a notifier for a state change of a
- *			      specific cable, not a entier set of cables of a
+ *			      specific cable, not an entire set of cables of a
  *			      extcon device.
  * @obj:	an empty extcon_specific_cable_nb object to be returned.
  * @extcon_name:	the name of extcon device.
@@ -498,7 +498,7 @@ int extcon_unregister_interest(struct extcon_specific_cable_nb *obj)
 }
 
 /**
- * extcon_register_notifier() - Register a notifee to get notified by
+ * extcon_register_notifier() - Register a notifiee to get notified by
  *			      any attach status changes from the extcon.
  * @edev:	the extcon device.
  * @nb:		a notifier block to be registered.
@@ -515,7 +515,7 @@ int extcon_register_notifier(struct extcon_dev *edev,
 EXPORT_SYMBOL_GPL(extcon_register_notifier);
 
 /**
- * extcon_unregister_notifier() - Unregister a notifee from the extcon device.
+ * extcon_unregister_notifier() - Unregister a notifiee from the extcon device.
  * @edev:	the extcon device.
  * @nb:		a registered notifier block to be unregistered.
  */
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(extcon_dev_register);
 
 /**
  * extcon_dev_unregister() - Unregister the extcon device.
- * @edev:	the extcon device instance to be unregitered.
+ * @edev:	the extcon device instance to be unregistered.
  *
  * Note that this does not call kfree(edev) because edev was not allocated
  * by this class.
diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index cdd4014..7443a56 100644
--- a/include/linux/extcon.h
+++ b/include/linux/extcon.h
@@ -30,19 +30,19 @@
 
 /*
  * The standard cable name is to help support general notifier
- * and notifee device drivers to share the common names.
+ * and notifiee device drivers to share the common names.
  * Please use standard cable names unless your notifier device has
  * a very unique and abnormal cable or
  * the cable type is supposed to be used with only one unique
- * pair of notifier/notifee devices.
+ * pair of notifier/notifiee devices.
  *
  * Please add any other "standard" cables used with extcon dev.
  *
  * You may add a dot and number to specify version or specification
  * of the specific cable if it is required. (e.g., "Fast-charger.18"
  * and "Fast-charger.10" for 1.8A and 1.0A chargers)
- * However, the notifee and notifier should be able to handle such
- * string and if the notifee can negotiate the protocol or idenify,
+ * However, the notifiee and notifier should be able to handle such
+ * string and if the notifiee can negotiate the protocol or identify,
  * you don't need such convention. This convention is helpful when
  * notifier can distinguish but notifiee cannot.
  */
@@ -76,7 +76,7 @@ struct extcon_cable;
  * struct extcon_dev - An extcon device represents one external connector.
  * @name	The name of this extcon device. Parent device name is used
  *		if NULL.
- * @supported_cable	Array of supported cable name ending with NULL.
+ * @supported_cable	Array of supported cable names ending with NULL.
  *			If supported_cable is NULL, cable name related APIs
  *			are disabled.
  * @mutually_exclusive	Array of mutually exclusive set of cables that cannot
@@ -95,7 +95,7 @@ struct extcon_cable;
  * @state	Attach/detach state of this extcon. Do not provide at
  *		register-time
  * @nh	Notifier for the state change events from this extcon
- * @entry	To support list of extcon devices so that uses can search
+ * @entry	To support list of extcon devices so that users can search
  *		for extcon devices based on the extcon name.
  * @lock
  * @max_supported	Internal value to store the number of cables.
@@ -199,7 +199,7 @@ extern int extcon_update_state(struct extcon_dev *edev, u32 mask, u32 state);
 /*
  * get/set_cable_state access each bit of the 32b encoded state value.
  * They are used to access the status of each cable based on the cable_name
- * or cable_index, which is retrived by extcon_find_cable_index
+ * or cable_index, which is retrieved by extcon_find_cable_index
  */
 extern int extcon_find_cable_index(struct extcon_dev *sdev,
 				   const char *cable_name);
@@ -226,9 +226,9 @@ extern int extcon_unregister_interest(struct extcon_specific_cable_nb *nb);
 
 /*
  * Following APIs are to monitor every action of a notifier.
- * Registerer gets notified for every external port of a connection device.
+ * Registrar gets notified for every external port of a connection device.
  * Probably this could be used to debug an action of notifier; however,
- * we do not recommend to use this at normal 'notifiee' device drivers who
+ * we do not recommend to use this for normal 'notifiee' device drivers who
  * want to be notified by a specific external port of the notifier.
  */
 extern int extcon_register_notifier(struct extcon_dev *edev,
-- 
1.7.9.5

[PATCH RESEND] extcon: fix typos in extcon-arizona

[Peter Meerwald]

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/extcon/extcon-arizona.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 427a289..6d24822 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -313,7 +313,7 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
 
 	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
 	if (!info) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+		dev_err(&pdev->dev, "Failed to allocate memory\n");
 		ret = -ENOMEM;
 		goto err;
 	}
@@ -350,7 +350,7 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
 
 	ret = extcon_dev_register(&info->edev, arizona->dev);
 	if (ret < 0) {
-		dev_err(arizona->dev, "extcon_dev_regster() failed: %d\n",
+		dev_err(arizona->dev, "extcon_dev_register() failed: %d\n",
 			ret);
 		goto err;
 	}
-- 
1.7.9.5

Re: [PATCH RESEND] extcon: fix typos in sys-class-extcon

[Chanwoo Choi]

On 08/23/2012 04:27 AM, Peter Meerwald wrote:

> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> ---
>  Documentation/ABI/testing/sysfs-class-extcon |   22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-extcon b/Documentation/ABI/testing/sysfs-class-extcon
> index 20ab361..57a7262 100644
> --- a/Documentation/ABI/testing/sysfs-class-extcon
> +++ b/Documentation/ABI/testing/sysfs-class-extcon
> @@ -13,7 +13,7 @@ Description:
>  		accessory cables have such capability. For example,
>  		the 30-pin port of Nuri board (/arch/arm/mach-exynos)
>  		may have both HDMI and Charger attached, or analog audio,
> -		video, and USB cables attached simulteneously.
> +		video, and USB cables attached simultaneously.
>  
>  		If there are cables mutually exclusive with each other,
>  		such binary relations may be expressed with extcon_dev's
> @@ -35,7 +35,7 @@ Description:
>  		The /sys/class/extcon/.../state shows and stores the cable
>  		attach/detach information of the corresponding extcon object.
>  		If the extcon object has an optional callback "show_state"
> -		defined, the showing function is overriden with the optional
> +		defined, the showing function is overridden with the optional
>  		callback.
>  
>  		If the default callback for showing function is used, the
> @@ -46,19 +46,19 @@ Description:
>  		TA=1
>  		EAR_JACK=0
>  		#
> -		In this example, the extcon device have USB_OTG and TA
> +		In this example, the extcon device has USB_OTG and TA
>  		cables attached and HDMI and EAR_JACK cables detached.
>  
>  		In order to update the state of an extcon device, enter a hex
> -		state number starting with 0x.
> -		 echo 0xHEX > state
> +		state number starting with 0x:
> +		# echo 0xHEX > state
>  
> -		This updates the whole state of the extcon dev.
> +		This updates the whole state of the extcon device.
>  		Inputs of all the methods are required to meet the
> -		mutually_exclusive contidions if they exist.
> +		mutually_exclusive conditions if they exist.
>  
>  		It is recommended to use this "global" state interface if
> -		you need to enter the value atomically. The later state
> +		you need to set the value atomically. The later state
>  		interface associated with each cable cannot update
>  		multiple cable states of an extcon device simultaneously.
>  
> @@ -73,7 +73,7 @@ What:		/sys/class/extcon/.../cable.x/state
>  Date:		February 2012
>  Contact:	MyungJoo Ham <myungjoo.ham@samsung.com>
>  Description:
> -		The /sys/class/extcon/.../cable.x/name shows and stores the
> +		The /sys/class/extcon/.../cable.x/state shows and stores the
>  		state of cable "x" (integer between 0 and 31) of an extcon
>  		device. The state value is either 0 (detached) or 1
>  		(attached).
> @@ -83,8 +83,8 @@ Date:		December 2011
>  Contact:	MyungJoo Ham <myungjoo.ham@samsung.com>
>  Description:
>  		Shows the relations of mutually exclusiveness. For example,
> -		if the mutually_exclusive array of extcon_dev is
> -		{0x3, 0x5, 0xC, 0x0}, the, the output is:
> +		if the mutually_exclusive array of extcon device is
> +		{0x3, 0x5, 0xC, 0x0}, then the output is:
>  		# ls mutually_exclusive/
>  		0x3
>  		0x5


Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.

Thank you
Chanwoo Choi

Re: [PATCH RESEND] extcon: fix typos in max77693 driver

[Chanwoo Choi]

On 08/23/2012 04:27 AM, Peter Meerwald wrote:

> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> ---
>  drivers/extcon/extcon-max77693.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
 

This patch is already applied by Myungjoo Ham, so you can check it
following git repository.
-
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next

Thank you
Chanwoo Choi

Re: [PATCH RESEND] extcon: fixing typos

[Chanwoo Choi]

On 08/23/2012 04:27 AM, Peter Meerwald wrote:

> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> ---
>  drivers/extcon/extcon_class.c |    8 ++++----
>  include/linux/extcon.h        |   18 +++++++++---------
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 


This patch is already replied by Myungjoo Ham, so you can check it
following git repository.
-
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next.

But, file name of 'extcon_class.c' has been modified from extcon_class.c
to extcon-class.c,
so i did modify and apply it. you can see patch which rename file
name(extcon-class.c, extcon-gpio.c)

http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commit;h=0ea62503782699adf5757cb1d3cd9f880d13c48c

Thank you,
Chanwoo Choi

Re: [PATCH RESEND] extcon: fix typos in extcon-arizona

[Chanwoo Choi]

On 08/23/2012 04:27 AM, Peter Meerwald wrote:

> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> ---
>  drivers/extcon/extcon-arizona.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 427a289..6d24822 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -313,7 +313,7 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
>  
>  	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>  	if (!info) {
> -		dev_err(&pdev->dev, "failed to allocate memory\n");
> +		dev_err(&pdev->dev, "Failed to allocate memory\n");
>  		ret = -ENOMEM;
>  		goto err;
>  	}
> @@ -350,7 +350,7 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
>  
>  	ret = extcon_dev_register(&info->edev, arizona->dev);
>  	if (ret < 0) {
> -		dev_err(arizona->dev, "extcon_dev_regster() failed: %d\n",
> +		dev_err(arizona->dev, "extcon_dev_register() failed: %d\n",
>  			ret);
>  		goto err;
>  	}


Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.

Thank you
Chanwoo Choi