Re: [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen

Greg KH
2011-05-03T14:07:17Z

On Tue, May 03, 2011 at 01:02:08PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: PM: Print a warning if firmware is requested when tasks are frozen
>
> Some drivers erroneously use request_firmware() from their ->resume()
> (or ->thaw(), or ->restore()) callbacks, which is not going to work
> unless the firmware has been built in. This causes system resume to
> stall until the firmware-loading timeout expires, which makes users
> think that the resume has failed and reboot their machines
> unnecessarily. For this reason, make _request_firmware() print a
> warning and return immediately with error code if it has been called
> when tasks are frozen and it's impossible to start any new usermode
> helpers.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

I'm guessing you will take this through your tree? If so, that's great:

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>