Re: [RFC][PATCH] PM: Print a warning if firmware is requested when tasks are frozen

Greg KH
2011-05-03T14:07:09Z

On Mon, May 02, 2011 at 05:59:22PM -0700, Linus Torvalds wrote:
> On Mon, May 2, 2011 at 4:28 PM, Greg KH <gregkh@suse.de> wrote:
> >
> > A driver that does not rely on the firmware being built in would be
> > correct in calling request_firmware_nowait() on resume, then when
> > userspace is properly woken up, the firmware would be sent to the
> > device, then the driver would be notified, load it, and handle things
> > as part of its resume sequence from that notification.
> >
> > Isn't that ideally what we want to have happen?
>
> No. Absolutely not.
>
> What we ideally want to happen is for the driver to not be a stupid
> piece of sh*t.

Well, we all want that :)

> A driver that needs firmware loading at resume time IS A BROKEN DRIVER.
>
> It really is that simple.

Ok, fair enough, then I have no objection to this patch. It will let us
catch those shitty drivers and fix them up to not do this.

thanks,

greg k-h