public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <liuj97@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Unable to mount NFSROOT: pcie change breaks e1000?
Date: Fri, 24 Aug 2012 22:42:07 +0800	[thread overview]
Message-ID: <503792BF.1030601@gmail.com> (raw)
In-Reply-To: <CAErSpo6MepO=Ms+WBqfJmcGH0oZBJbnuYNuswavcF+mdqs2uZw@mail.gmail.com>

On 08/24/2012 12:12 AM, Bjorn Helgaas wrote:
> On Thu, Aug 23, 2012 at 9:03 AM, Jiang Liu <liuj97@gmail.com> wrote:
>> Hi Bjorn,
>>         Could you please help to fold this small patch into
>> "[5/40] PCI/core: Use PCI Express Capability accessors"?
>> It fixes a bug reported by Fengguang.
> 
> Thanks, I folded it in.  I looked briefly at whether a similar fix is
> needed in pci_restore_pcie_state().  I don't *think* so, but it
> wouldn't hurt for you to also double-check and let me know if it does.

I think it's optional to add a "pci_is_pcie()" check for pci_restore_pcie_state().
pci_find_saved_cap(dev, PCI_CAP_ID_EXP) should return NULL for non-PCIe device.

--Gerry


      reply	other threads:[~2012-08-24 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  0:46 Unable to mount NFSROOT: pcie change breaks e1000? Fengguang Wu
2012-08-23  1:31 ` Jiang Liu
2012-08-23  2:33   ` Fengguang Wu
2012-08-23 15:03   ` Jiang Liu
2012-08-23 16:12     ` Bjorn Helgaas
2012-08-24 14:42       ` Jiang Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503792BF.1030601@gmail.com \
    --to=liuj97@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox