Re: [PATCH v4 12/25] scsi: ufs: mediatek: Remove vendor kernel quirks cruft

Peter Wang (王信友)
2026-01-09T06:20:38Z

On Thu, 2026-01-08 at 10:28 +0100, Nicolas Frattaroli wrote:
> By "one software supporting multiple hardware configurations", do you
> mean one device tree? Because if so, I don't think that's a good
> idea.

Yes.

> Device tree is meant to describe non-enumerable hardware.

I agree.

>
> Even if you want to make it easier for your customers to ship one
> image
> for several SKUs, there's better ways to do this than having drivers
> fix up individual DT nodes. The platform firmware like u-boot can
> choose
> a DT based on differences it can probe. E.g. on Radxa ROCK 5B/5B+
> boards,
> we have u-boot choose between the 5B and 5B+ DT based on whether
> LPDDR5
> is present, as 5B does not have LPDDR5, so as long as u-boot is told
> it's
> either a ROCK 5B or ROCK 5B+, it can figure out which one
> specifically based
> on that. Similarly, for whichever boards this is for, there may be
> differences that can be probed to disambiguate between several SKUs
> of the
> board as long as it's known it must be at least one of those SKUs.

We will adopt this approach. Thank you for your suggestion.