* [PATCH] block: remove the duplicated setting for congestion_threshold
@ 2012-08-31 8:24 Jaehoon Chung
2012-09-09 10:44 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jaehoon Chung @ 2012-08-31 8:24 UTC (permalink / raw)
To: lkml; +Cc: axboe, Kyungmin Park
Before call the blk_queue_congestion_threshold(),
the blk_queue_congestion_threshold() is already called at blk_queue_make_rquest().
Because this code is the duplicated, it has removed.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
block/blk-core.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 4b4dbdf..a418249 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -713,8 +713,6 @@ blk_init_allocated_queue(struct request_queue *q, request_fn_proc *rfn,
if (elevator_init(q, NULL))
return NULL;
- blk_queue_congestion_threshold(q);
-
/* all done, end the initial bypass */
blk_queue_bypass_end(q);
return q;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: remove the duplicated setting for congestion_threshold
2012-08-31 8:24 [PATCH] block: remove the duplicated setting for congestion_threshold Jaehoon Chung
@ 2012-09-09 10:44 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2012-09-09 10:44 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: lkml, Kyungmin Park
On 2012-08-31 10:24, Jaehoon Chung wrote:
> Before call the blk_queue_congestion_threshold(),
> the blk_queue_congestion_threshold() is already called at blk_queue_make_rquest().
> Because this code is the duplicated, it has removed.
So it is, good catch. Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-09 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-31 8:24 [PATCH] block: remove the duplicated setting for congestion_threshold Jaehoon Chung
2012-09-09 10:44 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox