From: Cruz Julian Bishop <cruzjbishop@gmail.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: mcgrof@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...
Date: Sat, 01 Sep 2012 07:55:45 +1000 [thread overview]
Message-ID: <504132E1.1080508@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1208312008210.14761@swampdragon.chaosbits.net>
On 01/09/12 04:09, Jesper Juhl wrote:
> On Fri, 31 Aug 2012, Cruz Julian Bishop wrote:
>
>> ...and a big step for learning more Perl.
>>
>> Hi!
>>
>> This patch set started off as an experiment, but as I continued, I
>> realised that I should submit this and see if it's suitable for merging
>> into Linux.
>>
>> To start off with, here's some patches for checkincludes.pl
>>
>> This set was created for the following purposes:
>>
>> 1: Making it slightly easier to read
>> 2: Making it easier to extend and add new arguments
>> 3: Changing the usage output to look more "correct"
>> 4: Introducing a 'quiet' mode like checkpatch.pl, and printing
>> messages for files without duplicated includes by default
>>
>> Sorry if I did anything wrong - It's my first time really
>> experimenting with Perl.
>>
>> Thanks in advance.
>>
>> ~Cruz
>>
>> Cruz Julian Bishop (4):
>> scripts/checkincludes.pl: Print usage with heredoc
>> scripts/checkincludes.pl: Simplify and shorten argument logic
>> scripts/checkincludes.pl: Fix a bug introduced in the last commit
>> scripts/checkincludes.pl: Introduce 'quiet' mode
>>
>> scripts/checkincludes.pl | 113 ++++++++++++++++++++++++++--------------------
>> 1 file changed, 65 insertions(+), 48 deletions(-)
>>
>>
> Minor detail. Your patches are for "scripts/checkincludes.pl" but the
> subject says "scripts/checkpatch.pl"... You may want to get it straight
> what you are patching and let the subject reflect reality :-)
>
Yeah, I ended up writing the cover letter at 11:30 at night without any
coffee :-)
I'll look at a link that Joe Perches sent me then resubmit this
Thanks.
~Cruz
prev parent reply other threads:[~2012-08-31 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 13:18 [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 1/4] scripts/checkincludes.pl: Print usage with heredoc Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 2/4] scripts/checkincludes.pl: Simplify and shorten argument logic Cruz Julian Bishop
2012-08-31 15:42 ` Joe Perches
2012-08-31 21:54 ` Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 3/4] scripts/checkincludes.pl: Fix a bug introduced in the last commit Cruz Julian Bishop
2012-08-31 13:18 ` [PATCH 4/4] scripts/checkincludes.pl: Introduce 'quiet' mode Cruz Julian Bishop
2012-08-31 13:23 ` [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux Cruz Julian Bishop
2012-08-31 18:09 ` Jesper Juhl
2012-08-31 21:55 ` Cruz Julian Bishop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504132E1.1080508@gmail.com \
--to=cruzjbishop@gmail.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox