From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337AbbJSJB6 (ORCPT ); Mon, 19 Oct 2015 05:01:58 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59552 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbbJSJB4 (ORCPT ); Mon, 19 Oct 2015 05:01:56 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: WEN Pingbo , dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem Date: Mon, 19 Oct 2015 11:01:50 +0200 Message-ID: <5041745.xAgMz1TQSE@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445161459-26918-1-git-send-email-pingbo.wen@linaro.org> References: <1445161459-26918-1-git-send-email-pingbo.wen@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vRrSXAerxWpHYAukgLubIpDbQyTSaNMzmP3xAxODvyu1kADgqfZ ZBWSed/aVT1fTrJ5xeBcbJiKnjpYLT/ZZYoiob6l1JYy7G/2HP6OQTmielQFaV0DSL+xoTV 678Fe7fIYF7evCOAkNTdWtr4us4su0/CKZrftV+upmzRwS7pLzgGicckza29H0jwLAr1kcu +WRHIfzQ9gspl6HjBDg6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:RSE6T+1m34Q=:L21Y0VjVZ3m/mMaQyn6CHk Su7ACfb5ohEObRjBeo9HdiBKeZDxCPldCo1jkuZite+xk9r3FVEo1NYKYwMibOnb56OXkzQwn C/uz5zITwxl1zxULzKlKsr30P8ItLMw64yucQhF1AMKybZ5RwyJdor4T2PcObZCvu7CufnXG/ HzU/0S4HQaMRzG2VZIqC0YIcJveoYiFt9WSCYUQF8Vq8igwwbLs2R5jyuWvp5FF14bwAJB7DZ vFaQXeExROi2UUIwdZgVKa8qoAVhapEFkLaI/hrE3V2YxFxbsjIWjR1p/AQEzd1WY132i+y+g IgQ64csXpdW50kRQChBhQhx9MiGcGhf6RgHPCbbfewqFBRJtPBgWC0ElhOuEdDslBLr194dhv xG1OkWrYjb4QjBINVj//DCIj4QXVZKbcbnlkNDaBRTWvWj2n/nKXEO3NG+zA2jFRIj+HgOWG3 7bWvmtywajQFSaCQOe3MQuvO/7mPmoVszrKQ6Vo0/UgDO+J/+hAiTytIrKtf0Am7KyCUgEO17 L60VX7JsBtSNYFiMCSX8NkUgKZ9rTlDNGcOfs+R9ny/aXYvHHs91lKDnfX6SUImXF5mHd3EMC iQrQPFL8X08FeFHCuc+utyyhbGbS/wE3eMUUKQ3yix+LkWzgiJo4mH18e20RGWw5uysWypXCY byjdF5gCvpHglNf/GX1AabCAO4Qo7N6VbWbhxX231OVxB3Ki36F6Sx2R61cCTLwkkasdHk9vQ NZL4QMkGwkn2gO/m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 18 October 2015 17:44:19 WEN Pingbo wrote: > Two replacements happened in this patch: > 1. using timespec64 to prevent time overflow in 2038 > 2. using ktime_get_ts64 to avoid wall time issues(leap second, etc) > > Signed-off-by: WEN Pingbo > The patch looks correct, but I think this could be written a little simpler and clearer using ktime_get() or ktime_getns(). Arnd