Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock

Christoph Lameter
2012-09-05T13:55:38Z

On Wed, 5 Sep 2012, Michael Wang wrote:

> Since the cachep and cachep->slabp_cache's l3 alien are in the same lock class,
> fake report generated.

Ahh... That is a key insight into why this occurs.

> This should not happen since we already have init_lock_keys() which will
> reassign the lock class for both l3 list and l3 alien.

Right. I was wondering why we still get intermitted reports on this.

> This patch will invoke init_lock_keys() after we done enable_cpucache()
> instead of before to avoid the fake DEADLOCK report.

Acked-by: Christoph Lameter <cl@linux.com>