From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993Ab2IEN0q (ORCPT ); Wed, 5 Sep 2012 09:26:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40553 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130Ab2IEN0p (ORCPT ); Wed, 5 Sep 2012 09:26:45 -0400 Message-ID: <50475310.6000508@suse.cz> Date: Wed, 05 Sep 2012 15:26:40 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tzafrir Cohen Cc: Linux Kbuild , Linux Kernel , maximilian attems Subject: Re: [PATCH] builddeb: remove unneeded explicit Architecture References: <1344941092-31312-1-git-send-email-tzafrir.cohen@xorcom.com> <5040C112.70501@suse.cz> <20120905130528.GI18204@xorcom.com> In-Reply-To: <20120905130528.GI18204@xorcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5.9.2012 15:05, Tzafrir Cohen wrote: > Hi, > > Thanks for your reply, > > On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: >> Adding Max to CC. >> >> On 14.8.2012 12:44, Tzafrir Cohen wrote: >>> Architecture was set explicitly in debian/control for one of the three >>> packages (linux-libc-dev) but not for the other two. When cross-building >>> it gives me an error: >>> >>> dpkg-gencontrol: error: current host architecture 'armhf' does not >>> appear in package's architecture list (amd64) >>> >>> Also note that if used, dpkg --print-architecture should have been >>> replaced with dpkg-architecture. >>> >>> Signed-off-by: Tzafrir Cohen >>> --- >>> scripts/package/builddeb | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb >>> index acb8650..d9c71a6 100644 >>> --- a/scripts/package/builddeb >>> +++ b/scripts/package/builddeb >>> @@ -252,13 +252,12 @@ mkdir -p "$destdir" >>> (cd $objtree; tar -c -f - -T "$objtree/debian/hdrobjfiles") | (cd $destdir; tar -xf -) >>> ln -sf "/usr/src/linux-headers-$version" "$kernel_headers_dir/lib/modules/$version/build" >>> rm -f "$objtree/debian/hdrsrcfiles" "$objtree/debian/hdrobjfiles" >>> -arch=$(dpkg --print-architecture) >>> >>> cat <> debian/control >>> >>> Package: $kernel_headers_packagename >>> Provides: linux-headers, linux-headers-2.6 >>> -Architecture: $arch >>> +Architecture: any >>> Description: Linux kernel headers for $KERNELRELEASE on $arch >>> This package provides kernel header files for $KERNELRELEASE on $arch >>> . >> >> As the package contains files from arch/$SRCARCH/include, I doubt that >> this is a valid change. > > But you optionally force the Architecture later on in build_package. > "Arhcitecture: any" in the source package states that the binary package > will be the one stated by the build system. Ah, OK. I don't know much about Debian packaging in fact. Max, could you have a look? The original thread is here: http://lkml.org/lkml/2012/8/14/133. I meant to add you to CC before, but apparently I forgot. Michal