From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BEF165F16 for ; Sat, 21 Feb 2026 15:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771687695; cv=none; b=NH0vlFWw2fqcNyaM1U2GCW3EJYPsxgQIOuJOlHLWO2b8mQDSYSGSNRQlAHJMO8WyfmWB7AwQ1/7ohpbyzxIHk//9pgS58CTijCZYrtXjb6iPxALyTSOB+zfSrvUtacMRKCwbPDz4fh1rWzGieg58GJcp2IxJoxh36bgfiORrkaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771687695; c=relaxed/simple; bh=5s92sJYFqlhkw0TjQVyNXDxEdcBPXkyRZyqBIwjAhEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p943vq9ZnTOHRnj2X2bW0qCRRZ1zhn3Xxrj723LKlgXyEaaVVp96iJgo1XVTvS2vIlCv0W4ijooys2qnZMudu7BXehiunDyQ8GQccKxPYf8rQOA4Q4/qJc2II2TQ46SVjJg8SAepEVjAKgARAqqEU2irTTwM3Br45bP1KZ4dF8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=VkSBeE4w; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="VkSBeE4w" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=5s92sJYFqlhkw0TjQVyNXDxEdcBPXkyRZyqBIwjAhEs=; b=VkSBeE4wVQtSaWBxrHrtzxO5Dw b5qIN4wJr2YcOGzIU/Xlg3pWbrTyCsp6zobMTx0Ue8OSKe8TH7s8AFGrgx3LecbOqhnjN1nQWz1VN n8nLX5mFn+22Qhs/my6L07QeKvapdQd3HY4Kb6syBeEvCT/Hyd6Es8WZp3OLylckrnpknSsHXJV8x GOfSI35BDJjj/VlvSYVkfXHsKjgiv+c/UztONWVSgeGXFn+DGenYmj6ovWS8ARJHHzCL9V2DqDhkg Y7t6e0PG5AxmfJky5xDWRrDmpuLTUwVBvjPBjIUgq9Tlw+G2O57Avteix1n8kAhwh3UjiBBcjQSM0 0Dri2gGw==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Shawn Lin , Felix Gu Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu Subject: Re: [PATCH] soc: rockchip: grf: Fix device node reference leak in rockchip_grf_init() Date: Sat, 21 Feb 2026 16:28:08 +0100 Message-ID: <50476327.XUcTiDjVJD@diego> In-Reply-To: <20260217-grf-v1-1-2088c966875d@gmail.com> References: <20260217-grf-v1-1-2088c966875d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Felix, Am Montag, 16. Februar 2026, 21:11:32 Mitteleurop=C3=A4ische Normalzeit sch= rieb Felix Gu: > In rockchip_grf_init(), when syscon_node_to_regmap fails, it returns > without calling of_node_put(), which causes a reference leak. >=20 > Add the missing of_node_put() call to fix it. >=20 > Fixes: 75fb63ae0312 ("soc: rockchip: grf: Support multiple grf to be hand= led") > Signed-off-by: Felix Gu Shawn was a bit earlier with a similar fix [0], so their patch will go in. Heiko [0] https://lore.kernel.org/all/1770814957-17762-1-git-send-email-shawn.lin= @rock-chips.com/