From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdJOUJn (ORCPT ); Sun, 15 Oct 2017 16:09:43 -0400 Received: from mout.web.de ([217.72.192.78]:51851 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbdJOUJm (ORCPT ); Sun, 15 Oct 2017 16:09:42 -0400 Subject: [PATCH 2/3] char/bsr: Improve a size determination in bsr_add_node() From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Cc: LKML References: Message-ID: <504858bd-8add-3820-541e-a3f0aa64df65@users.sourceforge.net> Date: Sun, 15 Oct 2017 22:09:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:n9kCt664j7pJcBTrdQP5cvaawTyOAZnJR4Qssnp1yTc7z1pY26R YpkE3Q483fmK7iAUd7tgFTh/UnCvJfyG2JD2bOFqPesy/wRYduEJqjrzMNwH3A9kLphbydA KW+pN8ISCzpIbgGlDTmFwAmalGq1tLcywr3RK9YIa6kdOw99ymBZVb5qNi2DoNaRYRCguOr wCwoDqOFlEIN0maxIgwOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:RIb0O6wHcEU=:HF4zrU75LKuUNaT0xq9mpY UfedljkAS9smCuPhL1eQVcb+vSUs14beG0OdIfiIDClLPBckdcpQW7QWZLxeoSdJTfAxPhfZ9 m7+/GB6SxknQdhY3VRhte7O7bl1tDKbRoKLo8/P+IrgWqbEjqxZA0am6P7EPEgfsg6toTgfmB qedim5sJqxhunUGSh3O4WxQruALeguEaansxtPOa55yhc2RF1aMJZ8pgvUimYVG+1A/zhqDET mjVN8yO5x6L0UdxHHh54E3OlHBBnQcj/28qXx/hXiVGyNy9vnwz5EO3mf/gIgB1SC7Zt0KGaN 0zGEzrUSljyL+As48vo01HU7kzCLeUTQMX3/F7pz8cAFGQ4m4ob9vabOvxLNtaGvXviGF1kUh ycctXlEs/exm7BHox8IOnFKxBBEE7wUv8+fjMPVYgaMZah0IboHLZlb7XTKkkHdUmYPdDJqEs 8ynvDYf2JgGPef15poxhJ83cTCLyom0kwHclEqMkB4YF022K34xfafxJV0UHY7L6hatQVt6qe C5HljZRKVvvQUQFSJ3FOVSuZDSnBQeegrq4UqAw+otAcWdkXN52bl8sU1lnHBFHgl90H4DkbC LsFcoAWrnVVvMd9sbyPeP9+UZt00dEqe6s2mpyqUNdAznwTl4EBvBkG2C6vbakTwyHzoPHF2I POBLyfXIOWDi7+GemMVgByO/X4rNC/PNyPu6dGoASinMBnpyrcmBFEy/jmnAJE9cCLKb/XJcN dQSP/HZxbMpsubrdB6xRBVKlUGFQU3BvaaFLfINICA2eLEt8o6B4LNDQQw1QIZikh7A8JZTzN A4TWSI5l/9jl7hfJF5Cy+khi+J1KZS5zKwPpPYZ2Czbv70KXJs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 15 Oct 2017 21:25:46 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/char/bsr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index 865eb457e539..d0597dfa4d88 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -197,8 +197,7 @@ static int bsr_add_node(struct device_node *bn) num_bsr_devs = bsr_bytes_len / sizeof(u32); for (i = 0 ; i < num_bsr_devs; i++) { - struct bsr_dev *cur = kzalloc(sizeof(struct bsr_dev), - GFP_KERNEL); + struct bsr_dev *cur = kzalloc(sizeof(*cur), GFP_KERNEL); struct resource res; int result; -- 2.14.2