From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY
Date: Fri, 07 Sep 2012 00:16:12 -0700 [thread overview]
Message-ID: <50499F3C.1070706@zytor.com> (raw)
In-Reply-To: <5049B4C102000078000998FE@nat28.tlf.novell.com>
On 09/06/2012 11:48 PM, Jan Beulich wrote:
>
> --- 3.6-rc4/arch/x86/Kconfig.cpu
> +++ 3.6-rc4-x86-minimum-cpu-family/arch/x86/Kconfig.cpu
> @@ -409,9 +409,9 @@ config X86_CMOV
> config X86_MINIMUM_CPU_FAMILY
> int
> default "64" if X86_64
> - default "6" if X86_32 && X86_P6_NOP
> - default "5" if X86_32 && X86_CMPXCHG64
> - default "4" if X86_32 && (X86_XADD || X86_CMPXCHG || X86_BSWAP || X86_WP_WORKS_OK)
> + default "6" if X86_P6_NOP || X86_CMOV
> + default "5" if X86_CMPXCHG64 || X86_TSC
> + default "4" if X86_XADD || X86_CMPXCHG || X86_BSWAP || X86_WP_WORKS_OK
> default "3"
>
Erk, this isn't right either. We're not supposed to include
CPUID-enumerable features here, so X86_CMOV, X86_CMPXCHG64 and X86_TSC
don't belong, and should instead be done via required-features.h.
What a mess.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-09-07 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 6:48 [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY Jan Beulich
2012-09-07 7:16 ` H. Peter Anvin [this message]
2012-09-07 7:31 ` Jan Beulich
2012-09-07 15:08 ` H. Peter Anvin
2012-09-07 7:36 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50499F3C.1070706@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).