From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] x86/xor: improve XMM register spill/fill
Date: Mon, 10 Sep 2012 07:05:48 -0700 [thread overview]
Message-ID: <504DF3BC.30708@zytor.com> (raw)
In-Reply-To: <504DFB5B020000780009A327@nat28.tlf.novell.com>
On 09/10/2012 05:38 AM, Jan Beulich wrote:
> +/*
> + * By forcing the alignment beyond the default of 16 bytes, we make the
> + * compiler guarantee the alignment. Passing -mincoming-stack-boundary=3
> + * (which would have been the better global alternative, as the kernel
> + * never guarantees better stack alignment) isn't permitted on x86-64.
> + */
The very latest gcc should handle it, and in fact we compile with
-mstack-alignment=3 if gcc accepts it (if it is not yet upstream it will
be soon.) This affects the validity of this patch.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-09-10 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:38 [PATCH 2/4] x86/xor: improve XMM register spill/fill Jan Beulich
2012-09-10 14:05 ` H. Peter Anvin [this message]
2012-09-10 14:46 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DF3BC.30708@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox