From: Lars-Peter Clausen <lars@metafoo.de>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Antony Pavlov <antonynpavlov@gmail.com>,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework
Date: Mon, 10 Sep 2012 17:20:34 +0200 [thread overview]
Message-ID: <504E0542.8020309@metafoo.de> (raw)
In-Reply-To: <1347278719-15276-1-git-send-email-thierry.reding@avionic-design.de>
On 09/10/2012 02:05 PM, Thierry Reding wrote:
> Hi,
>
I think v2 looks, good. Will give it some testing later.
> This small series fixes a build error due to a circular header
> dependency, exports the timer API so it can be used outside of
> the arch/mips/jz4740 tree and finally moves and converts the
> JZ4740 PWM driver to the PWM framework.
>
> Note that I don't have any hardware to test this on, so I had to
> rely on compile tests only. Patches 1 and 2 should probably go
> through the MIPS tree, while I can take patch 3 through the PWM
> tree. It touches a couple of files in arch/mips but the changes
> are unlikely to cause conflicts.
Patch 2 and 3 should probably go through the same tree since patch 3 depends
on patch 2. I'd like to see them both go through the PWM tree.
Patch 1 should go through the MIPS tree, but I still can't see why the issue
should occur nor does it happen for anybody else except for you. Instead of
moving the content over to the public irq.h I'd rather like to see the
private irq.h being renamed.
Thanks,
- Lars
>
> Thierry
>
> Thierry Reding (3):
> MIPS: JZ4740: Break circular header dependency
> MIPS: JZ4740: Export timer API
> pwm: Add Ingenic JZ4740 support
>
> arch/mips/include/asm/mach-jz4740/irq.h | 5 +
> arch/mips/include/asm/mach-jz4740/platform.h | 1 +
> arch/mips/include/asm/mach-jz4740/timer.h | 113 ++++++++++++++
> arch/mips/jz4740/Kconfig | 3 -
> arch/mips/jz4740/Makefile | 2 +-
> arch/mips/jz4740/board-qi_lb60.c | 1 +
> arch/mips/jz4740/irq.h | 23 ---
> arch/mips/jz4740/platform.c | 6 +
> arch/mips/jz4740/pwm.c | 177 ---------------------
> arch/mips/jz4740/time.c | 2 +-
> arch/mips/jz4740/timer.c | 4 +-
> arch/mips/jz4740/timer.h | 136 -----------------
> drivers/pwm/Kconfig | 12 +-
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-jz4740.c | 221 +++++++++++++++++++++++++++
> 15 files changed, 363 insertions(+), 344 deletions(-)
> delete mode 100644 arch/mips/jz4740/irq.h
> delete mode 100644 arch/mips/jz4740/pwm.c
> delete mode 100644 arch/mips/jz4740/timer.h
> create mode 100644 drivers/pwm/pwm-jz4740.c
>
next prev parent reply other threads:[~2012-09-10 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:05 [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Thierry Reding
2012-09-10 12:05 ` [PATCH v2 1/3] MIPS: JZ4740: Break circular header dependency Thierry Reding
2012-09-10 12:05 ` [PATCH v2 2/3] MIPS: JZ4740: Export timer API Thierry Reding
2012-09-10 12:05 ` [PATCH v2 3/3] pwm: Add Ingenic JZ4740 support Thierry Reding
2012-09-10 21:51 ` Lars-Peter Clausen
2012-09-11 5:02 ` Thierry Reding
2012-09-11 17:54 ` Lars-Peter Clausen
2012-09-10 15:20 ` Lars-Peter Clausen [this message]
2012-09-10 17:30 ` [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Thierry Reding
2012-09-11 17:56 ` Lars-Peter Clausen
2012-09-12 15:02 ` Thierry Reding
2012-09-22 7:41 ` Thierry Reding
2012-09-23 13:56 ` Ralf Baechle
2012-09-23 17:12 ` Thierry Reding
2012-09-27 19:48 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E0542.8020309@metafoo.de \
--to=lars@metafoo.de \
--cc=antonynpavlov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=maarten@treewalker.org \
--cc=ralf@linux-mips.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox