From: Ryan Mallon <rmallon@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: linus.walleij@linaro.org, grant.likely@secretlab.ca,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allow gpiolib to be a module
Date: Tue, 11 Sep 2012 16:17:33 +1000 [thread overview]
Message-ID: <504ED77D.90008@gmail.com> (raw)
In-Reply-To: <504DF63A020000780009A30B@nat28.tlf.novell.com>
On 10/09/12 22:16, Jan Beulich wrote:
> Without ARCH_REQUIRE_GPIOLIB there's no reason to force this code, when
> enabled, to always be built into the kernel, which requires only minor
> Makefile and source code adjustments.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> ---
<snip>
> +#ifdef MODULE
> +int __init gpiolib_init(void)
Should be static.
> +{
> + return gpiolib_sysfs_init() ?: gpiolib_debugfs_init();
I thought this was going to call gpiolib_sysfs_init() twice until I
looked at gcc's documentation. Maybe the less obtuse, and far more common:
int err;
err = gpiolib_sysfs_init();
if (err)
return err;
return gpiolib_debugfs_init();
?
> +}
> +module_init(gpiolib_init);
~Ryan
next prev parent reply other threads:[~2012-09-11 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:16 [PATCH] allow gpiolib to be a module Jan Beulich
2012-09-11 6:17 ` Ryan Mallon [this message]
2012-09-11 7:00 ` Jan Beulich
2012-09-11 17:38 ` Linus Walleij
2012-09-12 7:43 ` Jan Beulich
2012-09-12 15:53 ` Linus Walleij
2012-09-12 17:41 ` Randy Dunlap
2012-09-13 7:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504ED77D.90008@gmail.com \
--to=rmallon@gmail.com \
--cc=JBeulich@suse.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox