From: Ryan Mallon <rmallon@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: balbi@ti.com, "'Grant Likely'" <grant.likely@secretlab.ca>,
"'Linus Walleij'" <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: samsung: use pr_* instead of printk
Date: Tue, 11 Sep 2012 16:48:01 +1000 [thread overview]
Message-ID: <504EDEA1.1050108@gmail.com> (raw)
In-Reply-To: <002201cd8fe8$2aafa070$800ee150$%han@samsung.com>
On 11/09/12 16:39, Jingoo Han wrote:
> On Tuesday, September 11, 2012 3:31 PM Felipe Balbi wrote
>
>>
>> Hi,
>>
>> On Mon, Sep 10, 2012 at 08:59:11PM +0900, Jingoo Han wrote:
>>> This patch uses pr_* instead of printk.
>>>
>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>> ---
>>> drivers/gpio/gpio-samsung.c | 6 +++---
>>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
>>> index ba126cc..e38d990 100644
>>> --- a/drivers/gpio/gpio-samsung.c
>>> +++ b/drivers/gpio/gpio-samsung.c
>>> @@ -45,7 +45,7 @@
>>> #ifndef DEBUG_GPIO
>>> #define gpio_dbg(x...) do { } while (0)
>>> #else
>>> -#define gpio_dbg(x...) printk(KERN_DEBUG x)
>>> +#define gpio_dbg(x...) pr_debug(x)
>>> #endif
>>>
>>> int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
>>> @@ -926,10 +926,10 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
>>> #ifdef CONFIG_PM
>>> if (chip->pm != NULL) {
>>> if (!chip->pm->save || !chip->pm->resume)
>>> - printk(KERN_ERR "gpio: %s has missing PM functions\n",
>>> + pr_err("gpio: %s has missing PM functions\n",
>>> gc->label);
>>
>> I would rather see dev_* conversion instead.
>>
>> my 2 cents
>
> Hi Felipe Balbi,
>
> OK, I will replace printk(KERN_ERR...) with dev_err.
> Thank you.
I was going to suggest that also, but I don't think that there is a dev
pointer to use. The gpio_chip structure has an optional one, but from my
quick glance it didn't look like the Samsung driver was using it. I
could be wrong though. If I am, go with dev_err (and dev_dbg for
replacing the gpio_dbg statements).
~Ryan
next prev parent reply other threads:[~2012-09-11 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 11:59 [PATCH] gpio: samsung: use pr_* instead of printk Jingoo Han
2012-09-11 6:08 ` Ryan Mallon
2012-09-11 6:35 ` Jingoo Han
2012-09-11 6:30 ` Felipe Balbi
2012-09-11 6:39 ` Jingoo Han
2012-09-11 6:48 ` Ryan Mallon [this message]
2012-09-11 7:02 ` Jingoo Han
2012-09-11 11:57 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EDEA1.1050108@gmail.com \
--to=rmallon@gmail.com \
--cc=balbi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox