From: Benoit Cousson <b-cousson@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: <balbi@ti.com>, <linux@arm.linux.org.uk>,
<rob.herring@calxeda.com>, <grant.likely@secretlab.ca>,
<tony@atomide.com>, <rnayak@ti.com>, <hvaibhav@ti.com>,
<peter.ujfalusi@ti.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] arm/dts: Add twl6030-usb data
Date: Tue, 11 Sep 2012 11:26:44 +0200 [thread overview]
Message-ID: <504F03D4.5080800@ti.com> (raw)
In-Reply-To: <1347345381-4390-2-git-send-email-kishon@ti.com>
On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote:
> Add twl6030-usb data node in twl6030 device tree file
>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> arch/arm/boot/dts/omap4-panda.dts | 4 ++++
> arch/arm/boot/dts/omap4-sdp.dts | 4 ++++
> arch/arm/boot/dts/twl6030.dtsi | 5 +++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts
> index 9880c12..2999eba 100644
> --- a/arch/arm/boot/dts/omap4-panda.dts
> +++ b/arch/arm/boot/dts/omap4-panda.dts
> @@ -126,3 +126,7 @@
> ti,non-removable;
> bus-width = <4>;
> };
> +
> +&twlusb {
> + usb-supply = <&vusb>;
> +};
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 72216e9..d8290c0 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -226,3 +226,7 @@
> bus-width = <4>;
> ti,non-removable;
> };
> +
> +&twlusb {
> + usb-supply = <&vusb>;
> +};
> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
> index 3b2f351..8e3aac9 100644
> --- a/arch/arm/boot/dts/twl6030.dtsi
> +++ b/arch/arm/boot/dts/twl6030.dtsi
> @@ -83,4 +83,9 @@
> clk32kg: regulator@12 {
> compatible = "ti,twl6030-clk32kg";
> };
> +
> + twlusb: twl6030-usb {
That name should be a generic device class name is possible.
What is twl6030-usb exactly? an USB PHY?
> + compatible = "ti,twl6030-usb";
> + interrupts = < 4 10 >;
If this is for two interrupts, you'd better split them to avoid
confusion with irq specifiers that requires several attributes like for
the GIC.
+ interrupts = <4>, <10>; /* IRQ1 blabla, IRQ2 blabla*/
The comments are not mandatory assuming the binding is documented.
Regards,
Benoit
next prev parent reply other threads:[~2012-09-11 9:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 6:36 [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB Kishon Vijay Abraham I
2012-09-11 6:36 ` [PATCH v2 1/3] arm/dts: Add twl6030-usb data Kishon Vijay Abraham I
2012-09-11 9:26 ` Benoit Cousson [this message]
2012-09-11 9:39 ` ABRAHAM, KISHON VIJAY
2012-09-11 10:05 ` Benoit Cousson
2012-09-11 6:36 ` [PATCH v2 2/3] arm/dts: Add twl4030-usb data Kishon Vijay Abraham I
2012-09-11 10:09 ` Benoit Cousson
2012-09-11 11:07 ` ABRAHAM, KISHON VIJAY
2012-09-11 6:36 ` [PATCH v2 3/3] arm/dts: omap: Add usb_otg and glue data Kishon Vijay Abraham I
2012-09-11 10:18 ` Benoit Cousson
2012-09-11 8:25 ` [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB Benoit Cousson
2012-09-11 8:44 ` ABRAHAM, KISHON VIJAY
2012-09-11 9:11 ` Benoit Cousson
2012-09-11 9:16 ` ABRAHAM, KISHON VIJAY
2012-09-11 10:01 ` Benoit Cousson
2012-09-11 10:19 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F03D4.5080800@ti.com \
--to=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=hvaibhav@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox