Re: [PATCH 03/16] ARM: ep93xx: move platform_data definitions

Arnd Bergmann
2012-09-11T17:16:55Z

On Tuesday 11 September 2012, H Hartley Sweeten wrote:
> Arnd,
>
> What about gpio-ep93xx.h? It does not have any platform_data in
> it but the gpio driver (driver/gpio/gpio-ep93xx.c) does include it
> from the mach-* directory.

There are actually four such headers for ep93xx:

* mach/ep93xx-regs.h
sound/soc/ep93xx/ep93xx-i2s.c
sound/soc/ep93xx/ep93xx-pcm.c

* mach/gpio-ep93xx.h
drivers/gpio/gpio-ep93xx.c

* mach/hardware.h
drivers/gpio/gpio-ep93xx.c
drivers/input/keyboard/ep93xx_keypad.c
drivers/net/ethernet/cirrus/ep93xx_eth.c
sound/soc/ep93xx/edb93xx.c
sound/soc/ep93xx/ep93xx-i2s.c
sound/soc/ep93xx/ep93xx-pcm.c
sound/soc/ep93xx/simone.c
sound/soc/ep93xx/snappercl15.c

* mach/platform.h
drivers/ata/pata_ep93xx.c
drivers/misc/ep93xx_pwm.c

If you are planning to allow building a combined kernel for ep93xx and
another ARMv4/v5 platform, all of these inclusions need to be removed
and done differently, plus you also need to start using the common clock
subsystem and sparse-irq.

Any of those things would be greatly appreciated as a cleanup, but we're
not going to require them any time soon.

Arnd