From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756240Ab2IKRyT (ORCPT ); Tue, 11 Sep 2012 13:54:19 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:37802 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118Ab2IKRyS (ORCPT ); Tue, 11 Sep 2012 13:54:18 -0400 Message-ID: <504F7AC8.6070405@metafoo.de> Date: Tue, 11 Sep 2012 19:54:16 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120724 Icedove/3.0.11 MIME-Version: 1.0 To: Thierry Reding CC: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Antony Pavlov , Maarten ter Huurne Subject: Re: [PATCH v2 3/3] pwm: Add Ingenic JZ4740 support References: <1347278719-15276-1-git-send-email-thierry.reding@avionic-design.de> <1347278719-15276-4-git-send-email-thierry.reding@avionic-design.de> <504E60F4.9010309@metafoo.de> <20120911050211.GA23771@avionic-0098.mockup.avionic-design.de> In-Reply-To: <20120911050211.GA23771@avionic-0098.mockup.avionic-design.de> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2012 07:02 AM, Thierry Reding wrote: > On Mon, Sep 10, 2012 at 11:51:48PM +0200, Lars-Peter Clausen wrote: >> On 09/10/2012 02:05 PM, Thierry Reding wrote: >>> This commit moves the driver to drivers/pwm and converts it to the new >>> PWM framework. >>> >>> Signed-off-by: Thierry Reding >> >> Seems to work, thanks a lot. This one and patch 2: >> >> Acked-by: Lars-Peter Clausen >> Tested-by: Lars-Peter Clausen >> >> But I noticed a different problem. Some drivers using the pwm API depend on >> HAVE_PWM (e.g. the pwm beeper driver), but the generic PWM framework does not >> select HAVE_PWM, so I couldn't select the pwm beeper driver. Imo the generic >> PWM framework should select HAVE_PWM > > Does it also work if you add || PWM to the PWM beeper driver's depends? Should work, but to select HAVE_PWM would in my opinion have been cleaner. But since the custom implementations of the PWM API should be gone soon anyway it probably does not matter that much. - Lars