[PATCH v2 2/2] fs: add missing documentation to simple_xattr functions

Aristeu Rozanski
2012-09-11T20:28:22Z

[-- Attachment #1: simple_xattr_doc.txt --]
[-- Type: text/plain, Size: 1696 bytes --]

v2: add function documentation instead of adding a separate file under
Documentation/

Cc: Li Zefan <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Hillf Danton <dhillf@gmail.com>
Cc: Lennart Poettering <lpoetter@redhat.com>
Signed-off-by: Aristeu Rozanski <aris@redhat.com>

---
fs/xattr.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

Index: github/fs/xattr.c
===================================================================
--- github.orig/fs/xattr.c 2012-09-11 14:48:12.648072176 -0400
+++ github/fs/xattr.c 2012-09-11 15:33:14.502770685 -0400
@@ -892,8 +892,19 @@

}

-/*
- * xattr SET operation for in-memory/pseudo filesystems
+/**
+ * simple_xattr_set: xattr SET operation for in-memory/pseudo filesystems
+ * @xattrs: simple_xattr list
+ * @name: name of the new extended attribute
+ * @value: value of the new extended attribute. If NULL, will remove the
+ * attribute
+ * @flags: if XATTR_CREATE is set, no already existing extended attribute may
+ * exist. If XATTR_REPLACE is set, the extended attribute should exist.
+ *
+ * returns -ENOMEM for allocation failures, -EEXIST in case XATTR_CREATE is
+ * set in flags and an extended attribute with the same name exists,
+ * -ENODATA if XATTR_REPLACE is set in flags but no entry with the
+ * specified name exists.
*/
int simple_xattr_set(struct simple_xattrs *xattrs, const char *name,
const void *value, size_t size, int flags)
@@ -950,6 +961,9 @@
return used;
}

+/*
+ * Adds an extended attribute to the list
+ */
void simple_xattr_list_add(struct simple_xattrs *xattrs,
struct simple_xattr *new_xattr)
{