From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941134AbcHJTCi (ORCPT ); Wed, 10 Aug 2016 15:02:38 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:64656 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938796AbcHJTC1 (ORCPT ); Wed, 10 Aug 2016 15:02:27 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Baole Ni , Krzysztof =?utf-8?B?S296xYJvd3NraQ==?= , Wolfram Sang , Dave Airlie , "linux-kernel@vger.kernel.org" , Doug Anderson , Andrew Duggan , Kukjin Kim , Borislav Petkov , dougthompson@xmission.com, chuansheng.liu@intel.com, Guenter Roeck , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro Date: Wed, 10 Aug 2016 15:45:30 +0200 Message-ID: <5052478.g1CZhtD17T@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160802105246.30008-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:XWMKNaudx8w3rGkpCBK25GQNy1ajd0kQjS2961DUtxZMNL7Gp1s eMN/8Vc08TYgjCsrhWlHisbuB7JiA6Z2KAkHcl2kOvC2QLKjkYa7Ysy23MZmyVYHbCtNXij xjf/XxEvOG3ZfCHV88wYzhbyVEQ20EnF++GWp8SZQMnE8wzWJCra/GIoJCZfDdosOnQHkat aOB/1Rnt39EJCvp6bXdjw== X-UI-Out-Filterresults: notjunk:1;V01:K0:O1crSPMfwOQ=:5pi+lbLePQB8m05HIOJb+a /tgs6iRbKnER5FtKXPRwHRxKX+Sj1/xting1z5u4HqF0ZXQxYeAuxQJSaExtlsnuQBtndOirF QZsD7zzLF0npLjBdgSSHrr/TITRDlFAv5ht5uDThyQS/azFo1c4YzbIGOfsaI025S/hGtzKeU PT90uH+UOMPw292YuaCKcRxKakdwSlUBLMMK+Rvk+w2UngY+nJft+TMJwhSNJJOc4cLj+lWg2 aAp8kb/Pck0MZqVd2hQqGCyu/SPhNt6+a4RgL6Mr6b3qPT+srDOqTEEGCuDW0hZoUk+opdtUu rLs2f/uz23GhrntW2Z8K4tetOERnximjJAXoYTe79PcUlVY7366Py89FcUh95Vg4vegMLok/t MWPP8mJYnVOU1X59pnZI2sicb7ZIEwsfOkVfE4yrf4F/8m2Mfaok7xq9xxkoOO3FAubofeDfD q/snHCZ+bPq2hS/uAcwa6fEQHfLxkA1fX43+shudnJ63cY1144fq02OOyMxTQgqzrM6Kqg8Uu shvX0wvMwnrPKXqj9a+xOPmA61+hAiFg3HuarOe/9/T68Soc5mvTiG9mTKLZddYPthnPj4O7Y NCD8KY4iukeONNdTWL0K0E2G9tI4LZnyTKTQyLkZpMlYZXN54LUlG74fOA6/FxCGFXBnnapQn 3tKujwDre+SXex3aOPoonltIsTbdqQjwPcFygs557Nq2X5UYcyl+FZvpLkJl7QcrY7EPu2GSY i3jBW823y6ptwnk7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 10, 2016 3:02:05 PM CEST Linus Walleij wrote: > On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni wrote: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > > > Signed-off-by: Chuansheng Liu > > Signed-off-by: Baole Ni > > Acked-by: Linus Walleij > > I assume Wolfram will merge this. I assume not, see http://lwn.net/Articles/696227/ Arnd