public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error message
@ 2012-09-12 20:33 Alexandre Pereira da Silva
  2012-09-14 10:01 ` Roland Stigge
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Pereira da Silva @ 2012-09-12 20:33 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel,
	Roland Stigge
  Cc: Alexandre Pereira da Silva

This message is an debugging message. It's useful for finding protocol
details but it's not necessarily an error.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
 drivers/usb/gadget/lpc32xx_udc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
index 21a9861..d1cf1f4 100644
--- a/drivers/usb/gadget/lpc32xx_udc.c
+++ b/drivers/usb/gadget/lpc32xx_udc.c
@@ -2399,7 +2399,7 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc)
 
 		if (i < 0) {
 			/* setup processing failed, force stall */
-			dev_err(udc->dev,
+			dev_dbg(udc->dev,
 				"req %02x.%02x protocol STALL; stat %d\n",
 				reqtype, req, i);
 			udc->ep0state = WAIT_FOR_SETUP;
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error message
  2012-09-12 20:33 [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error message Alexandre Pereira da Silva
@ 2012-09-14 10:01 ` Roland Stigge
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Stigge @ 2012-09-14 10:01 UTC (permalink / raw)
  To: Alexandre Pereira da Silva
  Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel

On 12/09/12 22:33, Alexandre Pereira da Silva wrote:
> This message is an debugging message. It's useful for finding protocol
> details but it's not necessarily an error.
> 
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>

Acked-by: Roland Stigge <stigge@antcom.de>

Yes, the Kevin Wells at NXP confirmed this some time ago. Thanks!

> ---
>  drivers/usb/gadget/lpc32xx_udc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> index 21a9861..d1cf1f4 100644
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -2399,7 +2399,7 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc)
>  
>  		if (i < 0) {
>  			/* setup processing failed, force stall */
> -			dev_err(udc->dev,
> +			dev_dbg(udc->dev,
>  				"req %02x.%02x protocol STALL; stat %d\n",
>  				reqtype, req, i);
>  			udc->ep0state = WAIT_FOR_SETUP;


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-14 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-12 20:33 [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error message Alexandre Pereira da Silva
2012-09-14 10:01 ` Roland Stigge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox