From: Jonathan Cameron <jic23@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] iio: inkern: allocate zeroed memory
Date: Sat, 15 Sep 2012 10:28:09 +0100 [thread overview]
Message-ID: <50544A29.1080704@kernel.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF4C3E@DQHE02.ent.ti.com>
On 09/14/2012 02:24 AM, Kim, Milo wrote:
> Use kzalloc() rather than kmalloc() for initializing the iio_channel structure.
> This patch enables the iio_dev and iio_chan_spec are set to NULL.
> This may prevent the page fault problem because the pointer of iio_chan_spec
> is initialized as NULL.
>
> The iio_chan_spec is updated only in case that the IIO map has
> specific channel label.
> When the map has no ADC channel label, then the value of iio_chan_spec
> remains as invalid pointer.
> To prevent this problem, the pointer should be initialized as NULL.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
merged to togreg branch of iio.git
> ---
> drivers/iio/inkern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index b5afc2f..1faa240 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -130,7 +130,7 @@ struct iio_channel *iio_channel_get(const char *name, const char *channel_name)
> if (c == NULL)
> return ERR_PTR(-ENODEV);
>
> - channel = kmalloc(sizeof(*channel), GFP_KERNEL);
> + channel = kzalloc(sizeof(*channel), GFP_KERNEL);
> if (channel == NULL)
> return ERR_PTR(-ENOMEM);
>
>
prev parent reply other threads:[~2012-09-15 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 1:24 [PATCH RESEND] iio: inkern: allocate zeroed memory Kim, Milo
2012-09-15 9:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50544A29.1080704@kernel.org \
--to=jic23@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox