* [PATCH RESEND] iio: inkern: allocate zeroed memory
@ 2012-09-14 1:24 Kim, Milo
2012-09-15 9:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2012-09-14 1:24 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Use kzalloc() rather than kmalloc() for initializing the iio_channel structure.
This patch enables the iio_dev and iio_chan_spec are set to NULL.
This may prevent the page fault problem because the pointer of iio_chan_spec
is initialized as NULL.
The iio_chan_spec is updated only in case that the IIO map has
specific channel label.
When the map has no ADC channel label, then the value of iio_chan_spec
remains as invalid pointer.
To prevent this problem, the pointer should be initialized as NULL.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/iio/inkern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index b5afc2f..1faa240 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -130,7 +130,7 @@ struct iio_channel *iio_channel_get(const char *name, const char *channel_name)
if (c == NULL)
return ERR_PTR(-ENODEV);
- channel = kmalloc(sizeof(*channel), GFP_KERNEL);
+ channel = kzalloc(sizeof(*channel), GFP_KERNEL);
if (channel == NULL)
return ERR_PTR(-ENOMEM);
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] iio: inkern: allocate zeroed memory
2012-09-14 1:24 [PATCH RESEND] iio: inkern: allocate zeroed memory Kim, Milo
@ 2012-09-15 9:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2012-09-15 9:28 UTC (permalink / raw)
To: Kim, Milo
Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 09/14/2012 02:24 AM, Kim, Milo wrote:
> Use kzalloc() rather than kmalloc() for initializing the iio_channel structure.
> This patch enables the iio_dev and iio_chan_spec are set to NULL.
> This may prevent the page fault problem because the pointer of iio_chan_spec
> is initialized as NULL.
>
> The iio_chan_spec is updated only in case that the IIO map has
> specific channel label.
> When the map has no ADC channel label, then the value of iio_chan_spec
> remains as invalid pointer.
> To prevent this problem, the pointer should be initialized as NULL.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
merged to togreg branch of iio.git
> ---
> drivers/iio/inkern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index b5afc2f..1faa240 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -130,7 +130,7 @@ struct iio_channel *iio_channel_get(const char *name, const char *channel_name)
> if (c == NULL)
> return ERR_PTR(-ENODEV);
>
> - channel = kmalloc(sizeof(*channel), GFP_KERNEL);
> + channel = kzalloc(sizeof(*channel), GFP_KERNEL);
> if (channel == NULL)
> return ERR_PTR(-ENOMEM);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-15 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 1:24 [PATCH RESEND] iio: inkern: allocate zeroed memory Kim, Milo
2012-09-15 9:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox