From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757825AbbJILzB (ORCPT ); Fri, 9 Oct 2015 07:55:01 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56108 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbbJILy7 (ORCPT ); Fri, 9 Oct 2015 07:54:59 -0400 From: Arnd Bergmann To: "Tirdea, Irina" Cc: Dmitry Torokhov , Bastien Nocera , Aleksei Mamlin , "linux-input@vger.kernel.org" , Mark Rutland , "Purdila, Octavian" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v8 0/9] Goodix touchscreen enhancements Date: Fri, 09 Oct 2015 13:54:50 +0200 Message-ID: <5056173.1qyR0F9zS3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1F3AC3675D538145B1661F571FE1805F2F0FB74F@irsmsx105.ger.corp.intel.com> References: <1444314231-19206-1-git-send-email-irina.tirdea@intel.com> <53318623.Pp8rvnEWr4@wuerfel> <1F3AC3675D538145B1661F571FE1805F2F0FB74F@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:VB59ijQoRyiR1tlT34oBj1You7dcUrguYRqZLLUyDJBVajfMige OjGaWjxeTM8joM6POr8OMJnLtrd0+3F5H982MauIZm4/LkjgW7DnUyoOpUqJwN63zXwSzCT u5N5I6LGQR3CD9u82pMAzjKkPOThh45FQkJxduVzlRewlTrGQSd1e+lIHuTvQ2nAH7kQGuK FNeLBKuklSKpKr/kqbACQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:S79pzRyhVxY=:qbUtYoc3APmXkB8sCVr62F Ly2PqFX9bt/wm5jpN0VA5uO/Hqwr2QFgPH0qmJsnAd/woQoCD5C98b3RVDcsXdr29lznib2FS nTXpN3Pjw52qhnV4aZzOVLTdCMQZJWQYuthTQNHtbi41enNARRNcMYZPH8uGj+Kc3i4oO/1Xs wgrRT0fKlgUchiISK8NzBBl6AQM04dm7D/zGR8pVyIMS1Tuw4alO2I1djfud+DRsBIcliJ1bL fX0UM2X5ffwUx43C6H14fLGKJA7zhgZfbH/pgMlvRuoqikdADVEY0/9dJLdnsVH7eytQuBsEg Ta6caSD2et7C2ypCap+xKO1mCz0wWxKa/mxdSePsitGkBBBEY8ObsTqTxOzUhdfi/eN3kUaUu CO3xntatRXAb6L995Vsn05PgMppiO3qjE5sMomjoxFCe4obkK3EswVopTtxj3FyJAJlQzmAwG PQTzVRquj1qTL6emIPjc7z7dBgcx4BFkUuzBP2iBjm4LfmHZECDaLw/Oozow8AkpWz51NHjKM MM4EqS6mGA0fGOcpsLLoKvjdF1KGq5dLZ66ZjQz8S3Q2G0n5UDNz9neVaXgC8nEMxBEexJFYX kxet4fBczdL+kQrVITBTuVF44EvR4w9XKaQR2QZN4A0XOMkdD7qYh0KMsRUehCejvlRuIWSQc GaC/nmJ6M1sqeinHsMDlGJssLhcI3VqDZ4rmY/Q27mu2lOHC5sYbWMf63UcqCfWtqdF3bCSwb 95IUXVRg5CDIgjiu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 09 October 2015 11:02:01 Tirdea, Irina wrote: > > -----Original Message----- > > From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Arnd Bergmann > > Sent: 08 October, 2015 17:32 > > To: Tirdea, Irina > > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org > > Subject: Re: [PATCH v8 0/9] Goodix touchscreen enhancements > > > > On Thursday 08 October 2015 17:23:42 Irina Tirdea wrote: > > > Add several enhancements to the Goodix touchscreen driver. > > > > > > The new functionality is only available for devices that > > > declare named gpio pins for interrupt and reset in their > > > ACPI/DT configuration. > > > > > > Thanks, > > > Irina > > > > > > Changes in v8: > > > - only allow new functionality for devices that declare named > > > gpios (using _DSD properties in ACPI or named DT properties) > > > > > > > > > > Looks much cleaner this way, thanks! > > > > One remaining question: how would you handle the case where > > the hardware doesn't support configuring the int-gpios line > > as output but you still want to use the named gpios? > > > > The only reason to use named gpios is to enable the new functionality > introduced by this patch set (mainly reset and power management). > You cannot use only one gpio either (e.g. only reset gpio but not the > interrupt gpio), you need both for this functionality to work. > > If the hardware does not support using the interrupt gpio pin as output, > it should not declare the named int-gpio pin in ACPI. It is true that > we might later run into platforms that declare the int-gpio pin even if it > does not actually work (just like we now have the indexed gpio pins). > I could have added an additional property for this as you first suggested, > but if we can modify the ACPI to add it, we could simply remove the > named interrupt pin instead (that does not work anyway). Ok, got it. Thanks, Arnd