public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04
@ 2012-09-12 20:30 Alexandre Pereira da Silva
  2012-09-17  9:05 ` Roland Stigge
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Pereira da Silva @ 2012-09-12 20:30 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel,
	Roland Stigge
  Cc: Alexandre Pereira da Silva

The STOTG04 is an replacement for ISP1301.

Most of the registers on STOTG04 are the same as on ISP1301, but the
register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the
ST part.

This is a work around for this by using the interrupt source register that
should behave the same on both parts and has the needed information.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
 drivers/usb/gadget/lpc32xx_udc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
index f696fb9..21a9861 100644
--- a/drivers/usb/gadget/lpc32xx_udc.c
+++ b/drivers/usb/gadget/lpc32xx_udc.c
@@ -2930,10 +2930,10 @@ static void vbus_work(struct work_struct *work)
 
 		/* Get the VBUS status from the transceiver */
 		value = i2c_smbus_read_byte_data(udc->isp1301_i2c_client,
-						 ISP1301_I2C_OTG_CONTROL_2);
+						 ISP1301_I2C_INTERRUPT_SOURCE);
 
 		/* VBUS on or off? */
-		if (value & OTG_B_SESS_VLD)
+		if (value & INT_SESS_VLD)
 			udc->vbus = 1;
 		else
 			udc->vbus = 0;
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04
  2012-09-12 20:30 [PATCH] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Alexandre Pereira da Silva
@ 2012-09-17  9:05 ` Roland Stigge
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Stigge @ 2012-09-17  9:05 UTC (permalink / raw)
  To: Alexandre Pereira da Silva
  Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel

On 09/12/2012 10:30 PM, Alexandre Pereira da Silva wrote:
> The STOTG04 is an replacement for ISP1301.
> 
> Most of the registers on STOTG04 are the same as on ISP1301, but the
> register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the
> ST part.
> 
> This is a work around for this by using the interrupt source register that
> should behave the same on both parts and has the needed information.
> 
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>

Tested-by: Roland Stigge <stigge@antcom.de>

> ---
>  drivers/usb/gadget/lpc32xx_udc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> index f696fb9..21a9861 100644
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -2930,10 +2930,10 @@ static void vbus_work(struct work_struct *work)
>  
>  		/* Get the VBUS status from the transceiver */
>  		value = i2c_smbus_read_byte_data(udc->isp1301_i2c_client,
> -						 ISP1301_I2C_OTG_CONTROL_2);
> +						 ISP1301_I2C_INTERRUPT_SOURCE);
>  
>  		/* VBUS on or off? */
> -		if (value & OTG_B_SESS_VLD)
> +		if (value & INT_SESS_VLD)
>  			udc->vbus = 1;
>  		else
>  			udc->vbus = 0;


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-17  9:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-12 20:30 [PATCH] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Alexandre Pereira da Silva
2012-09-17  9:05 ` Roland Stigge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox