From: David Daney <ddaney.cavm@gmail.com>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 2/2] misc/at25: Add an .id_table to at25 to facilitate driver loading and binding.
Date: Mon, 17 Sep 2012 10:06:41 -0700 [thread overview]
Message-ID: <505758A1.1050205@gmail.com> (raw)
In-Reply-To: <CAMSQXEHXG=DGT7egbSfdNb2VFTXS+HQ0DoaA2v9dTX_2zn2pZg@mail.gmail.com>
On 09/17/2012 12:49 AM, Ivo Sieben wrote:
> Hi,
>
> 2012/8/22 David Daney <ddaney.cavm@gmail.com>:
>> From: David Daney <david.daney@cavium.com>
>>
>> /*-------------------------------------------------------------------------*/
>> +static const struct spi_device_id at25_id[] = {
>> + {"at25", 0},
>> + {"m95256", 0},
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(spi, at25_id);
>
> I use this driver for the ST M95040, M95020 & M95010 eeprom devices.
> So wouldn't it be better to use the "famliy" name for these chips
> ("m95" instead of "m95256").
>
These are matched against device tree compatible properties. You could
propose adding a generic "st,95xxx" compatible property and adding that
to the at25_id list. But I don't think we want to remove "m95256", as
we have deployed devices using this binding.
David Daney
prev parent reply other threads:[~2012-09-17 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 19:03 [PATCH 0/2] SPI EEPROM / device tree interaction improvements David Daney
2012-08-22 19:03 ` [PATCH 1/2] misc/at25, dt: Improve at25 SPI eeprom device tree bindings David Daney
2012-09-05 22:57 ` Rob Herring
2012-08-22 19:03 ` [PATCH 2/2] misc/at25: Add an .id_table to at25 to facilitate driver loading and binding David Daney
2012-09-17 7:49 ` Ivo Sieben
2012-09-17 17:06 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505758A1.1050205@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=david.daney@cavium.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox