From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format
Date: Tue, 18 Sep 2012 11:10:07 +0530 [thread overview]
Message-ID: <50580937.7000802@ti.com> (raw)
In-Reply-To: <5057D3A2.3040206@gmail.com>
On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote:
> Actually, I wonder if it is useful to have something like:.
Read and write differ only in the flag also it will be a deviation from
what $SUBJECT
would warrant. So could be a separate patch.
>
> #define I2C_WRITE(_addr, _buf, _len) { \
> .addr = _addr, \
> .buf = _buf, \
> .len = _len, \
> }
>
> #define I2C_READ(_addr, _buf, _len) { \
> .addr = _addr, \
> .buf = _buf, \
> .len = _len, \
> .flags = I2C_M_RD, \
> }
>
> and then write this as:
>
> struct i2c_msg msgs[2] = {
> I2C_WRITE(client->addr, reg_addr, sizeof(reg_addr)),
> I2C_READ(client->addr, buf, len),
> };
next prev parent reply other threads:[~2012-09-18 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 13:58 [PATCH 0/7] rtc: convert to c99 format Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format Shubhrajyoti D
2012-09-18 1:44 ` Ryan Mallon
2012-09-18 6:05 ` Shubhrajyoti
2012-09-18 6:10 ` Ryan Mallon
2012-09-17 13:58 ` [PATCH 2/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 3/7] " Shubhrajyoti D
2012-09-18 1:45 ` Ryan Mallon
2012-09-18 5:38 ` Shubhrajyoti
2012-09-18 1:51 ` Ryan Mallon
2012-09-18 5:40 ` Shubhrajyoti [this message]
2012-09-18 5:47 ` Ryan Mallon
2012-09-18 5:53 ` Julia Lawall
2012-09-17 13:58 ` [PATCH 4/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 5/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 6/7] " Shubhrajyoti D
2012-09-17 13:58 ` [PATCH 7/7] " Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50580937.7000802@ti.com \
--to=shubhrajyoti@ti.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox