From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756757Ab2IRGKs (ORCPT ); Tue, 18 Sep 2012 02:10:48 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:51443 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755770Ab2IRGKr (ORCPT ); Tue, 18 Sep 2012 02:10:47 -0400 Message-ID: <50581061.4040402@gmail.com> Date: Tue, 18 Sep 2012 16:10:41 +1000 From: Ryan Mallon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Shubhrajyoti CC: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format References: <1347890294-28467-1-git-send-email-shubhrajyoti@ti.com> <1347890294-28467-2-git-send-email-shubhrajyoti@ti.com> <5057D1E1.60507@gmail.com> <50580F38.5040801@ti.com> In-Reply-To: <50580F38.5040801@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/12 16:05, Shubhrajyoti wrote: > On Tuesday 18 September 2012 07:14 AM, Ryan Mallon wrote: >> On 17/09/12 23:58, Shubhrajyoti D wrote: >>> Convert the struct i2c_msg initialization to C99 format. This makes >>> maintaining and editing the code simpler. Also helps once other fields >>> like transferred are added in future. >>> >>> Signed-off-by: Shubhrajyoti D >>> --- >>> drivers/rtc/rtc-ds1672.c | 26 ++++++++++++++++++++++---- >>> 1 files changed, 22 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c >>> index 7fa67d0..b44b2a1 100644 >>> --- a/drivers/rtc/rtc-ds1672.c >>> +++ b/drivers/rtc/rtc-ds1672.c >>> @@ -37,8 +37,18 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) >>> unsigned char buf[4]; >>> >>> struct i2c_msg msgs[] = { >>> - {client->addr, 0, 1, &addr}, /* setup read ptr */ >>> - {client->addr, I2C_M_RD, 4, buf}, /* read date */ >>> + { >>> + .addr = client->addr, >>> + .flags = 0, >>> + .len = 1, >>> + .buf = &addr >>> + }, /* setup read ptr */ >> It would be nice to tabify the fields, and put the comments on their own >> lines while you are here. With the C99 format you can also omit fields >> which are initialised to zero. Like this: > For local structures also? Yes, C99 initialisers automatically clear all unspecified fields to zero. See: http://stackoverflow.com/questions/3374446/what-happens-to-fields-not-named-by-a-designated-initializer ~Ryan