From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365Ab2IRHhP (ORCPT ); Tue, 18 Sep 2012 03:37:15 -0400 Received: from bosmailout18.eigbox.net ([66.96.185.18]:43108 "EHLO bosmailout18.eigbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082Ab2IRHhN (ORCPT ); Tue, 18 Sep 2012 03:37:13 -0400 X-Greylist: delayed 2394 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Sep 2012 03:37:13 EDT X-Authority-Analysis: v=2.0 cv=K5CV6VqI c=1 sm=1 a=/XaHQKnrF6NNa+0Xh+aM/w==:17 a=bc2JKO6qiGsA:10 a=FB6NmUnAAagA:10 a=Vei7A3t7nWYA:10 a=8nJEP1OIZ-IA:10 a=uZyhaqkQpUgA:10 a=bJ0fqD8TFZgqkSadqForXVIPBlU=:19 a=2wgl_K4i_FsclDwl0eQA:9 a=wPNLvfGTeEIA:10 a=6thTdk0GfRoQwv0zj4iWMg==:117 X-EN-OrigOutIP: 10.20.18.15 X-EN-IMPSID: 0WxH1k0010KWaAJ01WxHM2 Message-ID: <50581084.2050007@yahoo.es> Date: Tue, 18 Sep 2012 14:11:16 +0800 From: Hein Tibosch User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Andy Shevchenko CC: Viresh Kumar , Vinod Koul , spear-devel@list.st.com, linux-kernel@vger.kernel.org, "ludovic.desroches" , Nicolas Ferre , Hans-Christian Egtvedt Subject: Re: [PATCH 0/7] dw_dmac: introduce autoconfiguration References: <1347867577-13170-1-git-send-email-andriy.shevchenko@linux.intel.com> In-Reply-To: <1347867577-13170-1-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-EN-UserInfo: 3946c951b80c12a8be5482963a0b1232:e0ae43bc192b431f8b69f09a37527cbc X-EN-AuthUser: hein@htibosch.net X-EN-OrigIP: 114.79.63.92 X-EN-OrigHost: unknown Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/2012 3:39 PM, Andy Shevchenko wrote: > Here is a patchset that allows to adapt the driver to the hardware > configuration during probe time. The hardware should have the specific optional > parameters enabled. Otherwise the driver will consider values stored in the > platform data. > > Additionally it brings support of the software LLP transfers. It means that > normal linked list transfer is substituted by set of single block transfers > transparently to the user. > > Comments are welcome. > > Andy Shevchenko (7): > dw_dmac: mark dwc_dump_chan_regs as inline > dw_dmac: fill optional encoded parameters in register structure > dw_dmac: get number of channels from hardware if possible > dw_dmac: autoconfigure block_size or use platform data > dw_dmac: autoconfigure data_width or get it via platform data > dw_dmac: check if controller supports LLP > dw_dmac: introduce software emulation of LLP transfers > > arch/arm/mach-spear13xx/spear13xx.c | 3 + > arch/avr32/mach-at32ap/at32ap700x.c | 3 + > drivers/dma/dw_dmac.c | 207 +++++++++++++++++++++++++++++------ > drivers/dma/dw_dmac_regs.h | 48 ++++++++ > include/linux/dw_dmac.h | 7 ++ > 5 files changed, 235 insertions(+), 33 deletions(-) Andy, The (embedded) dw dma on the AP7000 indeed does not support auto configuration (the register reads as zero) and so it needs the platform data. I tested the driver on AVR32 with the atmel-mci driver and it all worked well. I also tested the new software emulation of LLP mode by setting nollp for each channel to true. That also worked as expected. Tested-by: Hein Tibosch