From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755805Ab2ISGSq (ORCPT ); Wed, 19 Sep 2012 02:18:46 -0400 Received: from na3sys009aog132.obsmtp.com ([74.125.149.250]:49355 "EHLO na3sys009aog132.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755405Ab2ISGSp (ORCPT ); Wed, 19 Sep 2012 02:18:45 -0400 Message-ID: <505963F8.5000804@ti.com> Date: Wed, 19 Sep 2012 09:19:36 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120917 Thunderbird/15.0.1 MIME-Version: 1.0 To: Fengguang Wu CC: Samuel Ortiz , LKML Subject: Re: [PATCH] mfd: use IRQF_ONESHOT for twl6040 References: <20120919013051.GA14171@localhost> <20120919013238.GA14408@localhost> In-Reply-To: <20120919013238.GA14408@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2012 04:32 AM, Fengguang Wu wrote: > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > Make sure threaded IRQs without a primary handler are always request > with IRQF_ONESHOT. > > Signed-off-by: Fengguang Wu Acked-by: Peter Ujfalusi > --- > > Please take the patch only if it's a positive warning. Thanks! > > drivers/mfd/twl6040-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux.orig/drivers/mfd/twl6040-core.c 2012-09-18 08:22:36.381180459 +0800 > +++ linux/drivers/mfd/twl6040-core.c 2012-09-19 09:27:15.947969313 +0800 > @@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc > goto irq_init_err; > > ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY, > - NULL, twl6040_naudint_handler, 0, > + NULL, twl6040_naudint_handler, IRQF_ONESHOT, > "twl6040_irq_ready", twl6040); > if (ret) { > dev_err(twl6040->dev, "READY IRQ request failed: %d\n", >