* [PATCH] perf probe: Allow of casting an array of char to string
@ 2012-09-20 5:12 Hyeoncheol Lee
2012-09-20 9:37 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Hyeoncheol Lee @ 2012-09-20 5:12 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: LKML, Masami Hiramatsu, Srikar Dronamraju
Before casting a type of a variable to string,
convert_variable_type() confirms that the type is a pointer or
an array. if it is a pointer to char, it is casted to string.
but in case of an array of char, it isn't
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
---
tools/perf/util/probe-finder.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 1daf5c1..be03293 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -413,12 +413,12 @@ static int convert_variable_type(Dwarf_Die *vr_die,
dwarf_diename(vr_die), dwarf_diename(&type));
return -EINVAL;
}
+ if (die_get_real_type(&type, &type) == NULL) {
+ pr_warning("Failed to get a type"
+ " information.\n");
+ return -ENOENT;
+ }
if (ret == DW_TAG_pointer_type) {
- if (die_get_real_type(&type, &type) == NULL) {
- pr_warning("Failed to get a type"
- " information.\n");
- return -ENOENT;
- }
while (*ref_ptr)
ref_ptr = &(*ref_ptr)->next;
/* Add new reference with offset +0 */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf probe: Allow of casting an array of char to string
2012-09-20 5:12 [PATCH] perf probe: Allow of casting an array of char to string Hyeoncheol Lee
@ 2012-09-20 9:37 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2012-09-20 9:37 UTC (permalink / raw)
To: Hyeoncheol Lee
Cc: Arnaldo Carvalho de Melo, LKML, Srikar Dronamraju,
yrl.pp-manager.tt
(2012/09/20 14:12), Hyeoncheol Lee wrote:
> Before casting a type of a variable to string,
> convert_variable_type() confirms that the type is a pointer or
> an array. if it is a pointer to char, it is casted to string.
> but in case of an array of char, it isn't
Oops, right! I missed the array case. This must be fixed.
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thank you!
>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
> ---
> tools/perf/util/probe-finder.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 1daf5c1..be03293 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -413,12 +413,12 @@ static int convert_variable_type(Dwarf_Die *vr_die,
> dwarf_diename(vr_die), dwarf_diename(&type));
> return -EINVAL;
> }
> + if (die_get_real_type(&type, &type) == NULL) {
> + pr_warning("Failed to get a type"
> + " information.\n");
> + return -ENOENT;
> + }
> if (ret == DW_TAG_pointer_type) {
> - if (die_get_real_type(&type, &type) == NULL) {
> - pr_warning("Failed to get a type"
> - " information.\n");
> - return -ENOENT;
> - }
> while (*ref_ptr)
> ref_ptr = &(*ref_ptr)->next;
> /* Add new reference with offset +0 */
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-20 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-20 5:12 [PATCH] perf probe: Allow of casting an array of char to string Hyeoncheol Lee
2012-09-20 9:37 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox