From: Jeff Mahoney <jeffm@suse.de>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/kbuild: archscripts depends on scripts_basic
Date: Thu, 20 Sep 2012 10:28:45 -0400 [thread overview]
Message-ID: <505B281D.80405@suse.de> (raw)
In-Reply-To: <505A03EC.8090502@linux.intel.com>
While building the SUSE kernel packages, which build the scripts,
make clean, and then build everything, we have been running into spurious
build failures. We tracked them down to a simple dependency issue:
$ make mrproper
CLEAN arch/x86/tools
CLEAN scripts/basic
$ cp patches/config/x86_64/desktop .config
$ make archscripts
HOSTCC arch/x86/tools/relocs
/bin/sh: scripts/basic/fixdep: No such file or directory
make[3]: *** [arch/x86/tools/relocs] Error 1
make[2]: *** [archscripts] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
This was introduced by commit
6520fe55 (x86, realmode: 16-bit real-mode code support for relocs),
which added the archscripts dependency to archprepare.
This patch adds the scripts_basic dependency to the x86 archscripts.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
arch/x86/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -142,7 +142,7 @@ KBUILD_CFLAGS += $(call cc-option,-mno-a
KBUILD_CFLAGS += $(mflags-y)
KBUILD_AFLAGS += $(mflags-y)
-archscripts:
+archscripts: scripts_basic
$(Q)$(MAKE) $(build)=arch/x86/tools relocs
###
next prev parent reply other threads:[~2012-09-20 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:38 [PATCH[ Makefile: Fix scripts_basic / archscripts build order Jeff Mahoney
2012-09-19 17:42 ` H. Peter Anvin
2012-09-20 14:24 ` Jeff Mahoney
2012-09-20 14:28 ` Jeff Mahoney [this message]
2012-09-21 11:50 ` [PATCH] x86/kbuild: archscripts depends on scripts_basic Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B281D.80405@suse.de \
--to=jeffm@suse.de \
--cc=hpa@linux.intel.com \
--cc=kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox