From: Paul Parsons <lost.distance@yahoo.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: dwmw2@infradead.org, philipp.zabel@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pda_power: ac_draw used before set
Date: Fri, 21 Sep 2012 01:16:38 +0100 [thread overview]
Message-ID: <505BB1E6.3010502@yahoo.com> (raw)
In-Reply-To: <20120920213232.GA18223@lizard>
Hello Anton,
On 20/09/12 22:32, Anton Vorontsov wrote:
> On Wed, Sep 19, 2012 at 06:36:19PM +0100, Paul Parsons wrote:
>> When I reboot my iPAQ hx4700 in its cradle, the battery will not begin
>> to charge even though the AC supply is connected. Charging will start
>> only after the PDA power driver is tickled by some other power event,
>> such as reseating the iPAQ in its cradle or connecting the USB cable.
>>
>> The problem lies in pda_power_probe(), where ac_draw is used by the call
>> to update_charger() before being set by the call to regulator_get().
>>
>> Moving the regulator_get() call to before the update_charger() call
>> fixes the problem.
>>
>> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
>> Cc: Philipp Zabel <philipp.zabel@gmail.com>
>> ---
>
> Great to see that someone is still using hx4700. :-)
>
> Thanks for the patch, it is merged now!
I am having second thoughts about the goto ac_draw_failed I added.
This will cause pda_power_probe() to fail if regulator_get() fails.
However the way ac_draw is used - always after a check for NULL -
suggests that a failed call to regulator_get() was not fatal.
I am happy to submit another patch to remove the goto and label.
Regards,
Paul
next prev parent reply other threads:[~2012-09-21 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:36 [PATCH] pda_power: ac_draw used before set Paul Parsons
2012-09-20 21:32 ` Anton Vorontsov
2012-09-21 0:16 ` Paul Parsons [this message]
2012-09-21 0:20 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505BB1E6.3010502@yahoo.com \
--to=lost.distance@yahoo.com \
--cc=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox