From: Eric Sandeen <sandeen@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf: Fix parallel build
Date: Thu, 20 Sep 2012 20:08:19 -0500 [thread overview]
Message-ID: <505BBE03.80507@redhat.com> (raw)
In-Reply-To: <877groz0hh.fsf@sejong.aot.lge.com>
On 9/20/12 7:24 PM, Namhyung Kim wrote:
> Hi Eric,
>
> On Thu, 20 Sep 2012 18:53:01 -0500, Eric Sandeen wrote:
>> Parallel builds of perf were failing for me on a 32p box, with:
>>
>> * new build flags or prefix
>> util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
>>
>> ...
>>
>> make: *** [util/pmu-flex.o] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>> This can pretty quickly be seen by adding a sleep in front of
>> the bison call in tools/perf/Makefile and running make -j4 on a
>> smaller box:
>>
>> sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
>>
>> Adding the following dependency fixes it for me:
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
>> index bad726a..6c389d9 100644
>> --- a/tools/perf/Makefile
>> +++ b/tools/perf/Makefile
>> @@ -219,7 +219,7 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l
>> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
>> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
>>
>> -$(OUTPUT)util/pmu-flex.c: util/pmu.l
>> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
>> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
>>
>> $(OUTPUT)util/pmu-bison.c: util/pmu.y
>
> I guess the $(OUTPUT)util/parse-events-flex.c: line has the same
> problem. Could you check and submit a patch for that too?
>
> Thanks,
> Namhyung
>
Whoops you are right, will resent V2 shortly, thanks.
-Eric
next prev parent reply other threads:[~2012-09-21 1:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 23:53 [PATCH] perf: Fix parallel build Eric Sandeen
2012-09-21 0:24 ` Namhyung Kim
2012-09-21 1:08 ` Eric Sandeen [this message]
2012-09-21 1:12 ` [PATCH V2] " Eric Sandeen
2012-09-21 2:07 ` Namhyung Kim
2012-09-21 2:25 ` Eric Sandeen
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
2012-09-21 2:27 ` Namhyung Kim
2012-09-27 4:25 ` [tip:perf/core] perf tools: " tip-bot for Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505BBE03.80507@redhat.com \
--to=sandeen@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox