From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026Ab2IUBIY (ORCPT ); Thu, 20 Sep 2012 21:08:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63192 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467Ab2IUBIX (ORCPT ); Thu, 20 Sep 2012 21:08:23 -0400 Message-ID: <505BBE03.80507@redhat.com> Date: Thu, 20 Sep 2012 20:08:19 -0500 From: Eric Sandeen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Namhyung Kim CC: kernel list , Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf: Fix parallel build References: <505BAC5D.9020909@redhat.com> <877groz0hh.fsf@sejong.aot.lge.com> In-Reply-To: <877groz0hh.fsf@sejong.aot.lge.com> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/12 7:24 PM, Namhyung Kim wrote: > Hi Eric, > > On Thu, 20 Sep 2012 18:53:01 -0500, Eric Sandeen wrote: >> Parallel builds of perf were failing for me on a 32p box, with: >> >> * new build flags or prefix >> util/pmu.l:7:23: error: pmu-bison.h: No such file or directory >> >> ... >> >> make: *** [util/pmu-flex.o] Error 1 >> make: *** Waiting for unfinished jobs.... >> >> This can pretty quickly be seen by adding a sleep in front of >> the bison call in tools/perf/Makefile and running make -j4 on a >> smaller box: >> >> sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c >> >> Adding the following dependency fixes it for me: >> >> Signed-off-by: Eric Sandeen >> --- >> >> diff --git a/tools/perf/Makefile b/tools/perf/Makefile >> index bad726a..6c389d9 100644 >> --- a/tools/perf/Makefile >> +++ b/tools/perf/Makefile >> @@ -219,7 +219,7 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l >> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y >> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c >> >> -$(OUTPUT)util/pmu-flex.c: util/pmu.l >> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c >> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c >> >> $(OUTPUT)util/pmu-bison.c: util/pmu.y > > I guess the $(OUTPUT)util/parse-events-flex.c: line has the same > problem. Could you check and submit a patch for that too? > > Thanks, > Namhyung > Whoops you are right, will resent V2 shortly, thanks. -Eric