public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <cminyard@mvista.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: yakui.zhao@intel.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
Date: Thu, 20 Sep 2012 20:19:48 -0500	[thread overview]
Message-ID: <505BC0B4.4010306@mvista.com> (raw)
In-Reply-To: <1348177573-7537-1-git-send-email-mjg@redhat.com>

On 09/20/2012 04:46 PM, Matthew Garrett wrote:
> Drivers may make calls that require the ACPI IPMI driver to have been
> initialised already, so make sure that it appears earlier in the build
> order.

The IPMI driver uses the ACPI namespace as an option to know the address 
and characteristics of the device.  Does that still work?

-corey

>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
>   drivers/acpi/Makefile | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 47199e2..82422fe 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -47,6 +47,10 @@ acpi-y				+= video_detect.o
>   endif
>   
>   # These are (potentially) separate modules
> +
> +# IPMI may be used by other drivers, so it has to initialise before them
> +obj-$(CONFIG_ACPI_IPMI)		+= acpi_ipmi.o
> +
>   obj-$(CONFIG_ACPI_AC) 		+= ac.o
>   obj-$(CONFIG_ACPI_BUTTON)	+= button.o
>   obj-$(CONFIG_ACPI_FAN)		+= fan.o
> @@ -70,6 +74,5 @@ processor-y			+= processor_idle.o processor_thermal.o
>   processor-$(CONFIG_CPU_FREQ)	+= processor_perflib.o
>   
>   obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
> -obj-$(CONFIG_ACPI_IPMI)		+= acpi_ipmi.o
>   
>   obj-$(CONFIG_ACPI_APEI)		+= apei/


  parent reply	other threads:[~2012-09-21  1:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 21:46 [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers Matthew Garrett
2012-09-20 21:46 ` [PATCH 2/2] IPMI: Change link order Matthew Garrett
2012-09-21  1:19 ` Corey Minyard [this message]
2012-09-21  1:26   ` [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers Matthew Garrett
2012-09-21  2:08     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505BC0B4.4010306@mvista.com \
    --to=cminyard@mvista.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox