From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757530Ab2IUSb5 (ORCPT ); Fri, 21 Sep 2012 14:31:57 -0400 Received: from casper.infradead.org ([85.118.1.10]:34537 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755160Ab2IUSb4 (ORCPT ); Fri, 21 Sep 2012 14:31:56 -0400 Message-ID: <505CB289.2040307@kernel.dk> Date: Fri, 21 Sep 2012 20:31:37 +0200 From: Jens Axboe MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nitin Gupta , Seth Jennings , Dan Magenheimer , Konrad Rzeszutek Wilk , Greg Kroah-Hartman Subject: Re: Query of zram/zsmalloc promotion References: <20120912023914.GA31715@bbox> <20120921164112.GD4780@phenom.dumpdata.com> In-Reply-To: <20120921164112.GD4780@phenom.dumpdata.com> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012-09-21 18:41, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 12, 2012 at 11:39:14AM +0900, Minchan Kim wrote: >> Hi all, >> >> I would like to promote zram/zsmalloc from staging tree. >> I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get >> any response from you guys. >> >> I think zram/zsmalloc's code qulity is good and they >> are used for many embedded vendors for a long time. >> So it's proper time to promote them. >> >> The zram should put on under driver/block/. I think it's not >> arguable but the issue is which directory we should keep *zsmalloc*. >> >> Now Nitin want to keep it with zram so it would be in driver/blocks/zram/ >> But I don't like it because zsmalloc touches several fields of struct page >> freely(and AFAIRC, Andrew had a same concern with me) so I want to put >> it under mm/. > > I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more > appropriate since it is dealing with storing a bunch of pages in a nice > layout for great density purposes. >> >> In addtion, now zcache use it, too so it's rather awkward if we put it >> under dirver/blocks/zram/. >> >> So questions. >> >> To Andrew: >> Is it okay to put it under mm/ ? Or /lib? >> >> To Jens: >> Is it okay to put zram under drvier/block/ If you are okay, I will start sending >> patchset after I sort out zsmalloc's location issue. > > I would think it would be OK. We can certainly put it in drivers/block, I have no issue with that. -- Jens Axboe