From: "Arend van Spriel" <arend@broadcom.com>
To: "Stephen Warren" <swarren@wwwdotorg.org>
Cc: "Wei Ni" <wni@nvidia.com>,
krakesh@nvidia.com, ldewangan@nvidia.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Johannes Berg" <johannes@sipsolutions.net>
Subject: Re: [PATCH v2 5/5] ARM: tegra: enable brcmfmac in defconfig
Date: Fri, 21 Sep 2012 21:05:18 +0200 [thread overview]
Message-ID: <505CBA6E.3030304@broadcom.com> (raw)
In-Reply-To: <505C93A1.2040801@wwwdotorg.org>
On 09/21/2012 06:19 PM, Stephen Warren wrote:
> On 09/21/2012 08:39 AM, Arend van Spriel wrote:
>> On 09/21/2012 10:55 AM, Wei Ni wrote:
>>> New options enabled:
>>> * CFG80211_WEXT: (dependency)
>>> * BRCMFMAC: wlan driver, enable as module.
>>>
>>> Signed-off-by: Wei Ni <wni@nvidia.com>
>>> ---
>>> arch/arm/configs/tegra_defconfig | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/configs/tegra_defconfig
>>> b/arch/arm/configs/tegra_defconfig
>>> index adcf3c2..04b18ea 100644
>>> --- a/arch/arm/configs/tegra_defconfig
>>> +++ b/arch/arm/configs/tegra_defconfig
>>> @@ -73,6 +73,7 @@ CONFIG_BT_BNEP=y
>>> CONFIG_BT_HIDP=y
>>> CONFIG_BT_HCIBTUSB=m
>>> CONFIG_CFG80211=y
>>> +CONFIG_CFG80211_WEXT=y
>>
>> Any particular reason for enabling this? The driver does not
>> specifically need it. The option only allows use of WEXT dependent
>> user-space tools like iwconfig and iwlist. At least it is not needed by
>> brcmfmac driver hence it does not select it.
>>
>> You indicate there is a dependency. Could you elaborate?
>
> "Dependency" probably isn't correct.
>
> However, the intent of tegra_defconfig is to provide a useful
> configuration for Tegra boards. Without the ability to use
> iwconfig/iwlist, enabling the wireless driver doesn't seem useful; how
> would someone configure the wireless connection?
Let me explain. CFG80211 provides a netlink api called NL80211 which is
favorable over WEXT api. In user-space the iw tool is replacing iwconfig
and iwlist. Also wpa_supplicant has support for both wext and nl80211.
CFG80211_WEXT basically provides an adaptation/compatibility layer that
allows user-space tools to interact with cfg80211 drivers. However, it
is intended to be phased out so I would not recommend putting it in a
defconfig.
Gr. AvS
next prev parent reply other threads:[~2012-09-21 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 8:54 [PATCH v2 0/5] ARM: tegra: enable wlan for t20 and t30 Wei Ni
2012-09-21 8:54 ` [PATCH v2 1/5] ARM: tegra: set up wlan clocks for tegra dt Wei Ni
2012-09-21 8:54 ` [PATCH v2 2/5] ARM: dt: t20 seaboard: turn on the power for wlan Wei Ni
2012-09-21 8:54 ` [PATCH v2 3/5] ARM: dt: t20 ventana: set pinmux and " Wei Ni
2012-09-21 8:54 ` [PATCH v2 4/5] ARM: dt: t30 cardhu: " Wei Ni
2012-09-21 8:55 ` [PATCH v2 5/5] ARM: tegra: enable brcmfmac in defconfig Wei Ni
2012-09-21 14:39 ` Arend van Spriel
2012-09-21 16:19 ` Stephen Warren
2012-09-21 19:05 ` Arend van Spriel [this message]
2012-09-24 17:48 ` Stephen Warren
2012-10-15 21:18 ` [PATCH v2 0/5] ARM: tegra: enable wlan for t20 and t30 Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505CBA6E.3030304@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=krakesh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox