From: Jason Wessel <jason.wessel@windriver.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: <linux-kernel@vger.kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] kgdb: Fix warning with !CONFIG_DEBUG_RODATA
Date: Fri, 21 Sep 2012 16:01:55 -0500 [thread overview]
Message-ID: <505CD5C3.3020009@windriver.com> (raw)
In-Reply-To: <1348261150-12423-1-git-send-email-andi@firstfloor.org>
On 09/21/2012 03:59 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Fixes
>
> arch/x86/kernel/kgdb.c: In function ‘kgdb_arch_set_breakpoint’:
> arch/x86/kernel/kgdb.c:749:7: warning: unused variable ‘opc’ [-Wunused-variable]
>
> when CONFIG_DEBUG_RODATA is not defined.
>
This is already pending along with other fixes in kgdb-next / linux next for the 3.7 merge window.
Jason.
--
commit 9a15c35d16cf76482be076125f631f1193e29413
Author: Jason Wessel <jason.wessel@windriver.com>
Date: Wed Aug 8 21:12:19 2012 -0500
kgdb,x86: fix warning about unused variable
When compiling without CONFIG_DEBUG_RODATA the following
compiler warning is generated:
arch/x86/kernel/kgdb.c: In function 'kgdb_arch_set_breakpoint':
arch/x86/kernel/kgdb.c:749: warning: unused variable 'opc'
The variable instantiation needs to be inside the #ifdef to
make the warning go away.
Reported-by: Thiago Rafael Becker <trbecker@trbecker.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 3f61904..836f832 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -746,7 +746,9 @@ void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip
int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
{
int err;
+#ifdef CONFIG_DEBUG_RODATA
char opc[BREAK_INSTR_SIZE];
+#endif /* CONFIG_DEBUG_RODATA */
bpt->type = BP_BREAKPOINT;
err = probe_kernel_read(bpt->saved_instr, (char *)bpt->bpt_addr,
next prev parent reply other threads:[~2012-09-21 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 20:59 [PATCH] kgdb: Fix warning with !CONFIG_DEBUG_RODATA Andi Kleen
2012-09-21 21:01 ` Jason Wessel [this message]
2012-09-21 21:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505CD5C3.3020009@windriver.com \
--to=jason.wessel@windriver.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox