From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586Ab2IXK2p (ORCPT ); Mon, 24 Sep 2012 06:28:45 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:47264 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204Ab2IXK2o (ORCPT ); Mon, 24 Sep 2012 06:28:44 -0400 X-AuditID: b753bd60-91ec3ba0000047ca-5f-506035d96e0c X-AuditID: b753bd60-91ec3ba0000047ca-5f-506035d96e0c Message-ID: <506035D0.6040504@hitachi.com> Date: Mon, 24 Sep 2012 19:28:32 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar Cc: Borislav Petkov , Ingo Molnar , LKML , X86-ML , Borislav Petkov , Steven Rostedt Subject: Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly References: <1348062414-6578-1-git-send-email-bp@amd64.org> <505ADB6B.3070706@hitachi.com> <20120920092540.GB3611@gmail.com> <505AE3B5.6080401@hitachi.com> <20120920094017.GA4918@gmail.com> In-Reply-To: <20120920094017.GA4918@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/09/20 18:40), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2012/09/20 18:25), Ingo Molnar wrote: >>> >>> * Masami Hiramatsu wrote: >>> >>>> (2012/09/19 22:46), Borislav Petkov wrote: >>>>> From: Borislav Petkov >>>>> >>>>> I get >>>>> >>>>> arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared ‘static’ but never defined [-Wunused-function] >>>>> >>>>> on tip/auto-latest. >>>>> >>>>> Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it >>>>> is done in its callsites. >>>> >>>> Thank you for reporting and fixing :) >>> >>> Why is a forward declation needed, why isn't the function in the >>> proper spot in the file to begin with? >> >> There is no reason, ftrace-related things can also be moved on top. >> Borislav, could you move it? > > Could be moved into a separate file as well - we could have > arch/x86/kprobes/, with core.c, opt.c, ftrace.c and common.h in > it - possibly more in the future. OK, I'll break it into those pieces :) Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com