From: Stephen Warren <swarren@wwwdotorg.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>
Subject: Re: [PATCH] rtc: tps65910: Use platform_get_irq to get RTC irq details
Date: Mon, 24 Sep 2012 11:24:22 -0600 [thread overview]
Message-ID: <50609746.6020702@wwwdotorg.org> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DDF60158F@BGMAIL02.nvidia.com>
On 09/24/2012 12:18 AM, Venu Byravarasu wrote:
>> -----Original Message-----
>> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
>> Sent: Friday, September 21, 2012 9:21 PM
>> To: Venu Byravarasu
>> Cc: akpm@linux-foundation.org; a.zummo@towertech.it; linux-
>> kernel@vger.kernel.org; rtc-linux@googlegroups.com
>> Subject: Re: [PATCH] rtc: tps65910: Use platform_get_irq to get RTC irq
>> details
>>
>> On 09/21/2012 05:00 AM, Venu Byravarasu wrote:
>>> As RTC driver needs only irq number from platform data,
>>> using platform_get_irq(), instead of generic dev_get_platdata().
>>
>> I assume this patch depends on "mfd: tps65910: Add alarm interrupt of
>> TPS65910 RTC to mfd device list" which you posted just before? If so,
>> the two patches should go through the same tree to avoid "git bisect"
>> issues.
>>
>> Also, I thought you needed to fix the MFD driver to call
>> mfd_add_devices() only after all the IRQ stuff had been set up -
>> otherwise, when the RTC driver calls devm_request_threaded_irq(), the
>> parent IRQ domain that the IRQ points at won't exist, and the call will
>> fail.
>
> No, I do not agree completely here.
> Current patch just changes the way to get irq info in the RTC driver.
> If proper irq number is passed from MFD, then it proceeds further and deals with it.
> In case of missing valid irq info, this returns error as in earlier case.
>
> I agree with you that this patch alone cannot make RTC completely functional,
> till we get mfd patch as well.
>
> However should lack of mfd changes really block this patch, as these two are
> independent drivers.
OK, if this feature (either the RTC as a whole, or the RTC driver
retrieving and using the interrupt) doesn't already work, then as you
say there are no dependencies, so this is fine.
next prev parent reply other threads:[~2012-09-24 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 11:00 [PATCH] rtc: tps65910: Use platform_get_irq to get RTC irq details Venu Byravarasu
2012-09-21 15:51 ` Stephen Warren
2012-09-24 6:18 ` Venu Byravarasu
2012-09-24 17:24 ` Stephen Warren [this message]
2012-09-25 4:43 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50609746.6020702@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox