* [PATCH Resend] extcon: Fix return value in extcon_register_interest()
@ 2012-09-25 11:01 Sachin Kamat
2012-09-25 23:19 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-09-25 11:01 UTC (permalink / raw)
To: linux-kernel; +Cc: myungjoo.ham, cw00.choi, sachin.kamat, patches
Propagate the value returned from extcon_find_cable_index()
instead of -ENODEV. For readability, -EINVAL is returned in place of
the variable.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/extcon/extcon-class.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 946a318..6348b64 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -475,7 +475,7 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj,
obj->cable_index = extcon_find_cable_index(obj->edev, cable_name);
if (obj->cable_index < 0)
- return -ENODEV;
+ return -EINVAL;
obj->user_nb = nb;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH Resend] extcon: Fix return value in extcon_register_interest()
2012-09-25 11:01 [PATCH Resend] extcon: Fix return value in extcon_register_interest() Sachin Kamat
@ 2012-09-25 23:19 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2012-09-25 23:19 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, myungjoo.ham, patches, Greg KH
On 09/25/2012 08:01 PM, Sachin Kamat wrote:
> Propagate the value returned from extcon_find_cable_index()
> instead of -ENODEV. For readability, -EINVAL is returned in place of
> the variable.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
Applied, thank you.
You can check it after some hours at below git repository for Extcon.
-
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-25 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 11:01 [PATCH Resend] extcon: Fix return value in extcon_register_interest() Sachin Kamat
2012-09-25 23:19 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox