From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754534Ab2I0FEb (ORCPT ); Thu, 27 Sep 2012 01:04:31 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:35929 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab2I0FE3 (ORCPT ); Thu, 27 Sep 2012 01:04:29 -0400 Message-ID: <5063DE5A.6000202@pobox.com> Date: Thu, 27 Sep 2012 01:04:26 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: James Bottomley CC: linux-scsi@vger.kernel.org, LKML Subject: Re: [SCSI PATCH] sd: max-retries becomes configurable References: <20120924210049.GA18527@havoc.gtf.org> <1348546019.2457.3.camel@dabdike> <50613F72.4000302@pobox.com> <1348569508.2457.28.camel@dabdike> In-Reply-To: <1348569508.2457.28.camel@dabdike> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/2012 06:38 AM, James Bottomley wrote: > On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: >> Can you be more specific about sysfs location? A runtime-writable (via >> sysfs!) module parameter for a module-wide default seemed appropriate. > > Well, if it's really important, the same thing should happen with > retries as happened with timeout (it became a request_queue property), > but it could be hacked as a struct scsi_disk one with a corresponding > entry in sd_dis_attrs. Well, it is already a request property... but assigned at initialization from sd-specific code. sd also passes this through scmd->allowed to rq->retries. It could become a request_queue property, but that seems like a hack as it is simply passed right back into SCSI EH, for SCSI-specific disposition. Jeff