From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4545C001DE for ; Fri, 28 Jul 2023 18:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236846AbjG1S05 convert rfc822-to-8bit (ORCPT ); Fri, 28 Jul 2023 14:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236873AbjG1S01 (ORCPT ); Fri, 28 Jul 2023 14:26:27 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65BC24EDB; Fri, 28 Jul 2023 11:25:50 -0700 (PDT) Received: from [185.230.175.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qPS8p-0000d5-IO; Fri, 28 Jul 2023 20:24:43 +0200 From: Heiko Stuebner To: Jaehoon Chung , Ulf Hansson , Yangtao Li Cc: Yangtao Li , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void Date: Fri, 28 Jul 2023 20:24:42 +0200 Message-ID: <5065221.NG923GbCHz@phil> In-Reply-To: <20230727070051.17778-41-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> <20230727070051.17778-41-frank.li@vivo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 27. Juli 2023, 09:00:30 CEST schrieb Yangtao Li: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König > Signed-off-by: Yangtao Li Acked-by: Heiko Stuebner