From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alan Cox <alan@linux.intel.com>
Cc: <gregkh@linuxfoundation.org>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] serial/arc-uart: Add new driver
Date: Wed, 3 Oct 2012 12:40:35 +0530 [thread overview]
Message-ID: <506BE4EB.4010904@synopsys.com> (raw)
In-Reply-To: <20121002124707.32b70292@bob.linux.org.uk>
On Tuesday 02 October 2012 05:17 PM, Alan Cox wrote:
>> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS)
>> */ +int __attribute__((weak)) running_on_iss;
> Why not pass a quirks field in your platform data instead - much
> cleaner than a global.
I'd thought about it too. However the platform data is retrieved in
arc_uart_init_one() while it's usage in arc_serial_set_termios() will be
in a different call chain, meaning this info will have to be anyways
saved in "some" data structure - probably within struct arc_uart_port -
and that too per port - which is not clean either. However if you
strongly feel that the global is a must go - I can rework it that way.
thx,
-Vineet
prev parent reply other threads:[~2012-10-03 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 5:03 [PATCH v2] serial/arc-uart: Add new driver Vineet.Gupta1
2012-10-02 11:47 ` Alan Cox
2012-10-03 7:10 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506BE4EB.4010904@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox