From: Laxman Dewangan <ldewangan@nvidia.com>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] mfd: tps65090: move register access APIs to header
Date: Mon, 8 Oct 2012 11:25:08 +0530 [thread overview]
Message-ID: <50726ABC.4030502@nvidia.com> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DDF8AF387@BGMAIL02.nvidia.com>
On Monday 08 October 2012 11:07 AM, Venu Byravarasu wrote:
>> -----Original Message-----
>> From: Laxman Dewangan
>> Sent: Sunday, October 07, 2012 8:52 PM
>> To: sameo@linux.intel.com
>> Cc: linux-kernel@vger.kernel.org; Venu Byravarasu; Laxman Dewangan
>> Subject: [PATCH 4/5] mfd: tps65090: move register access APIs to header
>>
>> Since tps65090 register is accessed via regmap, moving
>> the register access APIs to header and making it as inline.
> Why should we move function implementation to header file?
> Also by making inline, doesn't the output binary size increase?
These function does not do much but just indirect the regmap calls so
not seeing much size increase but better execution.
Also it will remove the complexity and code sizes from mfd drivers. The
sub driver can use direct regmap calls if they want.
next prev parent reply other threads:[~2012-10-08 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 15:22 [PATCH 0/5] mfd: tps65090: cleanups and use regmap-irq for interrupt support Laxman Dewangan
2012-10-07 15:22 ` [PATCH 1/5] mfd: add battery charger in tps65090 sub devs Laxman Dewangan
2012-10-07 15:22 ` [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed Laxman Dewangan
2012-10-07 16:13 ` Joe Perches
2012-10-08 6:03 ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090 Laxman Dewangan
2012-10-08 5:40 ` Venu Byravarasu
2012-10-08 5:55 ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 4/5] mfd: tps65090: move register access APIs to header Laxman Dewangan
2012-10-08 5:37 ` Venu Byravarasu
2012-10-08 5:55 ` Laxman Dewangan [this message]
2012-10-07 15:22 ` [PATCH 5/5] mfd: tps65090: use regmap irq framework for interrupt support Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50726ABC.4030502@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox