RE: [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090

Venu Byravarasu
2012-10-08T05:40:49Z

> -----Original Message-----
> From: Laxman Dewangan
> Sent: Sunday, October 07, 2012 8:52 PM
> To: sameo@linux.intel.com
> Cc: linux-kernel@vger.kernel.org; Venu Byravarasu; Laxman Dewangan
> Subject: [PATCH 3/5] mfd: tps65090: remove unused member of struct
> tps65090
>
> Remove unused member from tps65090 data structure as

Remove unused members

> these are not used.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> drivers/mfd/tps65090.c | 6 +-----
> include/linux/mfd/tps65090.h | 11 -----------
> 2 files changed, 1 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index f95f7f6..3cfc9dc 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -269,12 +269,9 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
> return -ENOMEM;
> }
>
> - tps65090->client = client;
> tps65090->dev = &client->dev;
> i2c_set_clientdata(client, tps65090);
>
> - mutex_init(&tps65090->lock);
> -
> if (client->irq) {
> ret = tps65090_irq_init(tps65090, client->irq, pdata-
> >irq_base);
> if (ret) {
> @@ -284,8 +281,7 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
> }
> }
>
> - tps65090->rmap = devm_regmap_init_i2c(tps65090->client,
> - &tps65090_regmap_config);
> + tps65090->rmap = devm_regmap_init_i2c(client,
> &tps65090_regmap_config);

Indentation missing.

> if (IS_ERR(tps65090->rmap)) {
> ret = PTR_ERR(tps65090->rmap);
> dev_err(&client->dev, "regmap_init failed with err: %d\n",
> ret);
> diff --git a/include/linux/mfd/tps65090.h b/include/linux/mfd/tps65090.h
> index 6bc31d8..6c57622 100644
> --- a/include/linux/mfd/tps65090.h
> +++ b/include/linux/mfd/tps65090.h
> @@ -25,26 +25,15 @@
> #include <linux/irq.h>
>
> struct tps65090 {
> - struct mutex lock;
> struct device *dev;
> - struct i2c_client *client;
> struct regmap *rmap;
> struct irq_chip irq_chip;
> struct mutex irq_lock;
> int irq_base;
> - unsigned int id;
> -};
> -
> -struct tps65090_subdev_info {
> - int id;
> - const char *name;
> - void *platform_data;
> };
>
> struct tps65090_platform_data {
> int irq_base;
> - int num_subdevs;
> - struct tps65090_subdev_info *subdevs;
> };
>
> /*
> --
> 1.7.1.1