Re: [PATCH 4/5] mfd: tps65090: move register access APIs to header

Laxman Dewangan
2012-10-08T06:28:43Z

On Monday 08 October 2012 11:07 AM, Venu Byravarasu wrote:
>> -----Original Message-----
>> From: Laxman Dewangan
>> Sent: Sunday, October 07, 2012 8:52 PM
>> To: sameo@linux.intel.com
>> Cc: linux-kernel@vger.kernel.org; Venu Byravarasu; Laxman Dewangan
>> Subject: [PATCH 4/5] mfd: tps65090: move register access APIs to header
>>
>> Since tps65090 register is accessed via regmap, moving
>> the register access APIs to header and making it as inline.
> Why should we move function implementation to header file?
> Also by making inline, doesn't the output binary size increase?

These function does not do much but just indirect the regmap calls so
not seeing much size increase but better execution.
Also it will remove the complexity and code sizes from mfd drivers. The
sub driver can use direct regmap calls if they want.